[SSSD] [PATCH] add change password target to krb5 backend

Simo Sorce ssorce at redhat.com
Mon Aug 31 18:27:45 UTC 2009


On Mon, 2009-08-31 at 15:10 +0200, Sumit Bose wrote:
> Hi,
> 
> this patch adds the change password support for the kerberos backend.
> 
> I wonder if we want to support password reset by root via kerberos, i.e.
> allow root to change a user's password if a krb5 ticket with the needed
> privileges is available?

Patch looks good, the only remark I have is that even if the child exits
we should still try to free resources we allocate (krb libs invocations
may allocate buffers), to avoid leaks if we later change the code to be
more complex or copy the code elsewhere.

Otherwise I'd say it's an ACK (though I haven't tested the change
myself).

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list