[SSSD] [PATCH] ELAPI sinks and providers

Dmitri Pal dpal at redhat.com
Fri Aug 28 12:23:17 UTC 2009


>
> > I do not see any of those comments to be critical (unless of cause
> > others do).
> > I would prefer opening tickets to improve different areas and work on
> > them later and take this patch as is.
> > Any concerns or objections?
>
> No, none of this was critical, more like things I noticed reading the
> code.
Jakub, thanks again!

I tried the make flags you suggested and they worked.
I think it looks cleaner as you suggested.
So the change will be in the next patch.
I also already started eliminating stderr as a separate provider.

I hope to send a new patch later today.
It will add new functionality and correct some of the issues you brought up.
Are you Ok with this approach or you want me to rework the original
patch and then
add the new code separately? It would be a tough task but I can try.
Or may be you would prefer me squashing them together?
Or you would prefer acking this one and treating next patch separately?

One of the things that next patch fixes (that you have not noticed yet
(he-he))
is that I use "char *" in many places where it should be a "const char *".

-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/




More information about the sssd-devel mailing list