[SSSD] [Freeipa-devel] [PATCH] add configure check for errno_t

Sumit Bose sbose at redhat.com
Fri Aug 28 09:53:56 UTC 2009


On Thu, Aug 27, 2009 at 09:38:14AM -0400, Simo Sorce wrote:
> On Wed, 2009-08-26 at 13:25 +0200, Sumit Bose wrote:
> > 
> > I have include the check in the sss_client directory, but I'm
> > reluctant
> > to add it to common, too. IMO the maintainers of the packages should
> > decide if errno_t makes sense for them or not. A second argument would
> > be that in most cases there is no private header file where the
> > typedef
> > can be added.
> 
> Sumit,
> I can't do a successful build with this patch, it says errno_t is
> re-defined in sss_cli.h when parsing util.h
> 
> Does it depend on other patches ?
> Can you check it again against current master ?
> 

ah, sorry, the new patch contains a protection against double inclusion
of the typedef.

bye,
Sumit
-------------- next part --------------
>From f48fc08a67c2a67611547f509ad00a6ff35a35f2 Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose at redhat.com>
Date: Wed, 26 Aug 2009 13:18:19 +0200
Subject: [PATCH] add configure check for errno_t

---
 server/configure.ac     |    2 ++
 server/util/util.h      |    5 +++++
 sss_client/configure.ac |    2 ++
 sss_client/sss_cli.h    |    5 +++++
 4 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/server/configure.ac b/server/configure.ac
index d42f07e..071ad07 100644
--- a/server/configure.ac
+++ b/server/configure.ac
@@ -31,6 +31,8 @@ AM_CONDITIONAL([HAVE_GCC], [test "$ac_cv_prog_gcc" = yes])
 AC_CHECK_HEADERS(stdint.h dlfcn.h)
 AC_CONFIG_HEADER(config.h)
 
+AC_CHECK_TYPES([errno_t], [], [], [[#include <errno.h>]])
+
 m4_include([build_macros.m4])
 BUILD_WITH_SHARED_BUILD_DIR
 
diff --git a/server/util/util.h b/server/util/util.h
index 8796529..f289f9c 100644
--- a/server/util/util.h
+++ b/server/util/util.h
@@ -15,6 +15,11 @@
 #include "tevent.h"
 #include "ldb.h"
 
+#ifndef HAVE_ERRNO_T
+#define HAVE_ERRNO_T
+typedef int errno_t;
+#endif
+
 extern const char *debug_prg_name;
 extern int debug_level;
 extern int debug_timestamps;
diff --git a/sss_client/configure.ac b/sss_client/configure.ac
index df16641..01c717d 100644
--- a/sss_client/configure.ac
+++ b/sss_client/configure.ac
@@ -13,6 +13,8 @@ AM_GNU_GETTEXT_VERSION([0.14])
 
 AM_CONDITIONAL([HAVE_GCC], [test "$ac_cv_prog_gcc" = yes])
 
+AC_CHECK_TYPES([errno_t], [], [], [[#include <errno.h>]])
+
 m4_pattern_allow([AM_SILENT_RULES])
 AM_SILENT_RULES
 
diff --git a/sss_client/sss_cli.h b/sss_client/sss_cli.h
index f1ccba9..7e0d4db 100644
--- a/sss_client/sss_cli.h
+++ b/sss_client/sss_cli.h
@@ -15,6 +15,11 @@
 #include <pwd.h>
 #include <grp.h>
 
+#ifndef HAVE_ERRNO_T
+#define HAVE_ERRNO_T
+typedef int errno_t;
+#endif
+
 #define SSS_NSS_PROTOCOL_VERSION 1
 #define SSS_PAM_PROTOCOL_VERSION 2
 
-- 
1.6.2.5



More information about the sssd-devel mailing list