[SSSD] [Freeipa-devel] [PATCH] add configure check for errno_t

Stephen Gallagher sgallagh at redhat.com
Wed Aug 26 11:28:58 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/26/2009 07:25 AM, Sumit Bose wrote:
> On Mon, Jul 27, 2009 at 09:53:23AM -0400, Stephen Gallagher wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 07/24/2009 05:05 PM, Sumit Bose wrote:
>>> Hi,
>>>
>>> we regular use functions returning errno error code like ENOMEN or
>>> EINVAL. The return type of these functions is usually int. To underline
>>> that the return code is only an error code and should not be used
>>> otherwise a special type can be used. There is the ISO/ICE technical
>>> report 24731-1 which recommends they type errno_t for this purpose. I
>>> think it makes sense to stick with this recommendation (and I hope
>>> people don't mind that the same TR also recommends the not so smart *_s
>>> replacements for most of the standard libc functions).
>>>
>>> The attached patch add a configure check for errno_t and defines it if
>>> not present in the system.
>>>
>>> bye,
>>> Sumit
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> _______________________________________________
>>> Freeipa-devel mailing list
>>> Freeipa-devel at redhat.com
>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>
>> Nack.
>>
>> Please include a patch that modifies the configure scripts of the
>> sss_client and common directories.
>>
> 
> I have include the check in the sss_client directory, but I'm reluctant
> to add it to common, too. IMO the maintainers of the packages should
> decide if errno_t makes sense for them or not. A second argument would
> be that in most cases there is no private header file where the typedef
> can be added.
> 
> bye,
> Sumit

Ack.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkqVHHYACgkQeiVVYja6o6OBeQCdHK13vCxBd1YO7D2lEgrnsfpc
T4MAnicNh3z441hYoiTDvwVDoY41XqPH
=8E9y
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list