[SSSD] [PATCH] COMMON Fixes to return values, errno, leaks

Dmitri Pal dpal at redhat.com
Thu Aug 20 22:03:03 UTC 2009


Steve,

I re-based my source  and used the commit value of
93c02400b6075f0a4784e87229102bf751f27815 in the tickets but when I tried
to follow the automatically created link the track complained that the
commit doe not exist. Is this Ok?
Some synch delay?


Stephen Gallagher wrote:
> On 08/14/2009 11:09 PM, Dmitri Pal wrote:
> > Started looking at the ticket #107 related to
> > traverse functions. Realized that the return values
> > are not consistent. That overlapped with the work
> > that I wanted to do for ticket #103 - errno cleanup.
> > So I (across collection, INI and ELAPI):
> > * Made the return codes consistent (where found)
> > * Removed errno where it is not needed
> > While was testing used valgrind and found a nasty
> > problem when the value was added to collection with
> > overwriting duplicates the count was decreased improperly.
> > Fixing collection.c to not decrease count made
> > valgrind happy. While I was debugging this
> > I also spotted several build warnings in trace
> > statements when the " exp ? v1 : v2 " was used.
> > Fixed those.
> > In ini_config.c there was a trace statement that used
> > variable after it was freed. Removed trace statement.
>
>
>
> > ------------------------------------------------------------------------
>
> > _______________________________________________
> > sssd-devel mailing list
> > sssd-devel at lists.fedorahosted.org
> > https://fedorahosted.org/mailman/listinfo/sssd-devel
>
> Ack and pushed to master.
>
_______________________________________________
sssd-devel mailing list
sssd-devel at lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel

-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/




More information about the sssd-devel mailing list