[SSSD] [PATCH] COMMON Fixes to return values, errno, leaks

Stephen Gallagher sgallagh at redhat.com
Thu Aug 20 19:48:12 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/14/2009 11:09 PM, Dmitri Pal wrote:
> Started looking at the ticket #107 related to
> traverse functions. Realized that the return values
> are not consistent. That overlapped with the work
> that I wanted to do for ticket #103 - errno cleanup.
> So I (across collection, INI and ELAPI):
> * Made the return codes consistent (where found)
> * Removed errno where it is not needed
> While was testing used valgrind and found a nasty
> problem when the value was added to collection with
> overwriting duplicates the count was decreased improperly.
> Fixing collection.c to not decrease count made
> valgrind happy. While I was debugging this
> I also spotted several build warnings in trace
> statements when the " exp ? v1 : v2 " was used.
> Fixed those.
> In ini_config.c there was a trace statement that used
> variable after it was freed. Removed trace statement.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel

Ack and pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkqNqHwACgkQeiVVYja6o6P52ACfc2l8UVFzsJz8A8VaF6H3IY6a
bqEAmwfs2td8XGGr0+jY502LnKHJvKMj
=zgjt
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list