[SSSD] [PATCH] COMMON Fixes to return values, errno, leaks

Dmitri Pal dpal at redhat.com
Sat Aug 15 03:09:58 UTC 2009


Started looking at the ticket #107 related to
traverse functions. Realized that the return values
are not consistent. That overlapped with the work
that I wanted to do for ticket #103 - errno cleanup.
So I (across collection, INI and ELAPI):
* Made the return codes consistent (where found)
* Removed errno where it is not needed
While was testing used valgrind and found a nasty
problem when the value was added to collection with
overwriting duplicates the count was decreased improperly.
Fixing collection.c to not decrease count made
valgrind happy. While I was debugging this
I also spotted several build warnings in trace
statements when the " exp ? v1 : v2 " was used.
Fixed those.
In ini_config.c there was a trace statement that used
variable after it was freed. Removed trace statement.

-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-COMMON-Fixes-to-return-values-errno-leaks.patch
Type: text/x-patch
Size: 18734 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20090814/f1a1e0a7/attachment.bin>


More information about the sssd-devel mailing list