[SSSD] [PATCH] Make "files" a reserved word for legacy local domain

Jenny Galipeau jgalipea at redhat.com
Thu Aug 13 18:23:59 UTC 2009


Martin Nagy wrote:
> On Thu, 2009-08-13 at 13:12 +0200, Jakub Hrozek wrote:
>   
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 08/13/2009 10:02 AM, Martin Nagy wrote:
>>     
>>> Shouldn't you also check here if ctx->name is not "proxy" and the confdb
>>> parameter "libName" isn't set to "files"? I'm not 100% sure, but it
>>> seems to me, that if you have this in your sssd.conf:
>>>
>>> provider = proxy
>>> libName = files
>>>
>>> then ctx->name will still be set to "proxy" and your test in
>>> get_domain_type() will fail.
>>>
>>>       
>> Yes, this patch would break backwards compatibility (as well as setting
>> provider=proxy; libName=files manually), in tools, which is not great.
>>
>> So I've left the old way of detecting legacy local domain in
>> get_domain_type() for domains that are defined in the old way.
>>
>>     
>>> Also, I think it would be nice if you documented this shortcut in
>>> server/man/sssd.conf.5.xml and server/examples/sssd.conf.
>>>
>>>       
>> Done.
>>
>> New patch attached.
>>
>> 	Jakub
>>     
>
> Ack for the code. I'll let the person pushing this decide if the
> behavior itself is wanted.
>
> Martin
>   
Can someone please add the usage of this new provider to the SSSD HowTo 
page ... ? I would like to test it!!
Thanks
Jenny
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel
>
>   


-- 
Jenny Galipeau <jgalipea at redhat.com>
Principal Software QA Engineer
Red Hat, Inc. Security Engineering




More information about the sssd-devel mailing list