[SSSD] [PATCHES] services startup and identification

Simo Sorce ssorce at redhat.com
Tue Aug 11 13:33:13 UTC 2009


On Tue, 2009-08-11 at 08:41 -0400, Stephen Gallagher wrote:
> Patch 0002:
> Minor typo in client_registration: regeistration should be
> registration

ok

> Coding standard for dbus methods suggest the more readable:
> ret = dbus_message_append_args(reply,
>                                DBUS_TYPE_STRING, &version,
>                                DBUS_TYPE_INVALID);

ok

> Introduces a segmentation fault when an LDAP server is very slow. The
> ping timeout is hit and frees the connection, but it subsequently
> segfaults on a double-free.

I added a spy to the connection structure so that the svc reference is
removed when it goes away, this should fix the segfault.

> I'd rather that we moved the monitor versions to integers. We never
> actually used the dbus_get_monitor_version() call previously, so
> there's
> no ABI break if we simply move the version to 1 now.

the change in this patch is already a huge internal ABI and API break
anyway :-) But it doesn't matter until we reach v 1.0 and start seeing
people building external backends. Changed monitor version to be a hex
number as other ones.

> 600000 seconds is way too long a timeout for monitor_common_send_id.
> Prefer -1 (which libdbus defines as "a reasonable timeout") if you
> don't
> know what to set.

That's 600k milliseconds IIRC, not changing it as I simply reused what
was there before. We will have a session to review all timeouts and set
proper values once and for all.

Attached new 0002 patch with the included fixes.

Simo.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Change-services-identification-mechanism.patch
Type: application/mbox
Size: 44920 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20090811/830c1fe2/attachment.mbox>


More information about the sssd-devel mailing list