<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 10/2/13 2:42 PM, Shawn Wells wrote:<br>
</div>
<blockquote cite="mid:524C6903.10603@redhat.com" type="cite">
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode">On 10/2/13 12:57 PM, Jan
Lieskovsky wrote:
<br>
<blockquote type="cite" style="color: #000000;">Hello Shawn,
<br>
<br>
as promised, attached is slightly enhanced patch
<br>
for RHEL6's spec file it to quieten more rpmlint
<br>
warnings:
<br>
* spaces 've been replaced with tabs globally,
<br>
* removed dot from Summary,
<br>
* updated license && group,
<br>
* replaced hard-coded paths with rpm macros,
<br>
* adjusted defattr rpmlint not to complain about
<br>
invalid shebangs. For now kept defattr there
<br>
(since other RHEL6 specs do too), but according
<br>
to Fedora PackagingGuidelines (section File Permissions):
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines">https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines</a>
<br>
<br>
it was necessary only in versions of rpm package
<br>
prior to 4.4. Since in RHEL6 there's rpm-4.8.0 currently,
<br>
that macro might not be even needed already.
<br>
* adjusted scap-security-guide manual page definition
rpmlint
<br>
not to complain about missing %lang.
<br>
<br>
The rpmlint output has been reduced to two warnings / errors:
<br>
- one about the invalid source - as previously mentioned,
<br>
this is not something i can fix. Someone with proper
privileges
<br>
needs to upload the tarball to pre-agreed <a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://">https://</a> location first,
<br>
then that location needs to be listed after Source0:
section of
<br>
the spec file to calm down this warning,
<br>
</blockquote>
<br>
We should be able to take care of this today. Something like <a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://ssgproject.org/repos/">https://ssgproject.org/repos/</a>
<br>
<br>
A few of us are using the gov shutdown as an opportunity to
knock out much needed to-do's. Watch for patches/EMails on this
later today!
<br>
<br>
<blockquote type="cite" style="color: #000000;">- the other one
about the 'too much recursion / deep loop'
<br>
could be quieten by moving the Version and Release
information
<br>
from the main Makefile into the RHEL6's
scap-security-guide.spec
<br>
file (and for purpose of their use in the main Makefile
<br>
being extracted back from the spec file like Fedora case is
doing).
<br>
<br>
But since this impacts main Makefile and the way how RHEL6
<br>
versioning would behave, i am gonna to wait with the change
<br>
till someone else approves / confirms, fixing this
particular
<br>
rpmlint warning has higher priority than Version / Release
being
<br>
in the main Makefile.
<br>
</blockquote>
The RHEL RPM versioning should be updated to align with your
(very well thought out) scheme for Fedora. Please feel free to
update this!
<br>
<br>
<blockquote type="cite" style="color: #000000;">* didn't update
the changelog entry yet (for case this wouldn't be
<br>
the final version).
<br>
<br>
Please review.
<br>
</blockquote>
<br>
Ack.
<br>
<br>
Thank you for all your help on this! <br>
</div>
</blockquote>
<br>
Went ahead and pushed this patch, as I'm tinkering with Koji builds
tonight.<br>
</body>
</html>