<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 10/2/13 10:50 AM, Jan Lieskovsky
      wrote:<br>
    </div>
    <blockquote
      cite="mid:2042932658.365574.1380725403339.JavaMail.root@redhat.com"
      type="cite">
      <div class="moz-text-plain" wrap="true" graphical-quote="true"
        style="font-family: -moz-fixed; font-size: 12px;"
        lang="x-unicode">
        <pre wrap="">According to:
  <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://fedoraproject.org/wiki/Common_Rpmlint_issues">http://fedoraproject.org/wiki/Common_Rpmlint_issues</a>

hard-coded paths should be avoided in *.spec file:
  <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://fedoraproject.org/wiki/Packaging:RPMMacros?rd=Packaging/RPMMacros">https://fedoraproject.org/wiki/Packaging:RPMMacros?rd=Packaging/RPMMacros</a>

Also, while copying files file attributes should be preserved:
  <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps">https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps</a>

Therefore fix both issues in Fedora's spec file.

Thank you &amp;&amp; Regards, Jan.
--
Jan iankko Lieskovsky / Red Hat Security Technologies Team</pre>
      </div>
      <br>
      <fieldset class="mimeAttachmentHeader"><legend
          class="mimeAttachmentHeaderName">0002-Fedora-spec-replace-hard-wired-paths-with-macros.-Pr.patch</legend></fieldset>
      <br>
      <div class="moz-text-plain" wrap="true" graphical-quote="true"
        style="font-family: -moz-fixed; font-size: 12px;"
        lang="x-western">
        <pre wrap="">From 21df0dc9b8b3b1d303985a00b94f2baedf306d2b Mon Sep 17 00:00:00 2001
From: Jan Lieskovsky <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:jlieskov@redhat.com">&lt;jlieskov@redhat.com&gt;</a>
Date: Wed, 2 Oct 2013 16:03:02 +0200
Subject: [PATCH 2/2] Fedora spec - replace hard-wired paths with macros.
 Preserve attributes when copying files.


Signed-off-by: Jan Lieskovsky <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:jlieskov@redhat.com">&lt;jlieskov@redhat.com&gt;</a>
---
 Fedora/scap-security-guide.spec | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Fedora/scap-security-guide.spec b/Fedora/scap-security-guide.spec
index a323749..4ef3713 100644
--- a/Fedora/scap-security-guide.spec
+++ b/Fedora/scap-security-guide.spec
@@ -36,11 +36,10 @@ cd Fedora &amp;&amp; make dist
 
 %install
 rm -rf $RPM_BUILD_ROOT
-mkdir -p $RPM_BUILD_ROOT/usr/share/xml/scap/ssg/fedora/19
+mkdir -p $RPM_BUILD_ROOT%{_datadir}/xml/scap/ssg/fedora/19
 
 # Add in core content (SCAP, guide)
-cp -r Fedora/dist/* $RPM_BUILD_ROOT/usr/share/xml/scap/ssg/fedora/19
-
+cp -a Fedora/dist/* $RPM_BUILD_ROOT%{_datadir}/xml/scap/ssg/fedora/19
 
 %clean
 rm -rf $RPM_BUILD_ROOT
@@ -48,11 +47,12 @@ rm -rf $RPM_BUILD_ROOT
 
 %files
 %defattr(-,root,root,-)
-/usr/share/xml/scap/ssg/fedora/19/*
+%{_datadir}/xml/scap/ssg/fedora/19/*
 
 %changelog
 * Wed Oct 02 2013 Jan iankko Lieskovsky <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:jlieskov@redhat.com">&lt;jlieskov@redhat.com&gt;</a> 0.1-2.rc1
 - Set proper name of the build directory in the spec's %setup macro.
+- Replace hard-wired paths with macros. Preserve attributes when copying files.
 
 * Tue Sep 17 2013 Jan iankko Lieskovsky <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:jlieskov@redhat.com">&lt;jlieskov@redhat.com&gt;</a> 0.1-1
 - Initial Fedora SSG RPM.
<div class="moz-txt-sig">-- 
1.7.11.7</div></pre>
      </div>
    </blockquote>
    <br>
    Ran `make fedora-rpm` and yum localinstall, everything (file perms,
    etc) check out. Ack!<br>
  </body>
</html>