<div dir="ltr">While I can't comment on whether the intent is right or wrong, I don't think the suggested regular expression is quite correct. It may be giving you the result you expected, but probably not for the right reason. Inside the [] the (, ), and | characters lose their significance, so effectively that pattern is [^bcdhopt()|]. A value of "static" would pass based on the s, a, or i characters. "none" would pass because of the n or e characters. "dhcp" and "bootp" fail because they contain only characters that are not permitted. But "pchd" would also fail, as would any other permutation of the ten characters in the character class.<div>
<br></div><div>If you really want to allow anything other than "dhcp" or "bootp" it is probably easiest to use something like ^(dhcp|bootp)$ and then negate the test.<br><div><br></div><div><div style="color:rgb(136,136,136);font-family:arial,sans-serif;font-size:13.200000762939453px">
Shane Shaffer</div><div style="color:rgb(136,136,136);font-family:arial,sans-serif;font-size:13.200000762939453px">G2, Inc.</div><div style="color:rgb(136,136,136);font-family:arial,sans-serif;font-size:13.200000762939453px">
<a href="mailto:shane.shaffer@g2-inc.com" style="color:rgb(28,81,168)" target="_blank">shane.shaffer@g2-inc.com</a> </div></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jul 10, 2013 at 7:17 AM, Rui Pedro Bernardino <span dir="ltr"><<a href="mailto:rui-p-bernardino@ptinovacao.pt" target="_blank">rui-p-bernardino@ptinovacao.pt</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi all,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I think there’s a mistake on how sysconfig_networking_bootproto_ifcfg checks whether dhcp client is enabled. According to RHEL6 docs, BOOTPROTO should be one of “none”, “bootp” or “dhcp” and not “static”; /sbin/ifup assumes static IP configuration unless either “dhcp” or “bootp” is specified.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I suggest altering the check from ‘equals to “static”’ to ‘anything but “dhcp” or “bootp”’, which matches how it will be applied.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d">*** 22,28 ****<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d"> </ind:textfilecontent54_test><u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d"> <ind:textfilecontent54_state id="state_20135"<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d"> version="1"><u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d">! <b> <ind:subexpression operation="equals">static</ind:subexpression></b><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d"> </ind:textfilecontent54_state><u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d"> <ind:textfilecontent54_object id="obj_20135"<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d"> version="1"><u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d">--- 22,28 ----<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d"> </ind:textfilecontent54_test><u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d"> <ind:textfilecontent54_state id="state_20135"<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d"> version="1"><u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d">! <<b>ind:subexpression operation="pattern match">[^(dhcp|bootp)]</ind:subexpression></b><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d"> </ind:textfilecontent54_state><u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d"> <ind:textfilecontent54_object id="obj_20135"<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Consolas;color:#1f497d"> version="1"><u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Regards<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<div><p class="MsoNormal"><span lang="PT" style="font-size:10.5pt;font-family:Consolas;color:#1f497d">--<u></u><u></u></span></p><p class="MsoNormal"><span lang="PT" style="font-size:10.5pt;font-family:Consolas;color:#1f497d">Rui Pedro Bernardino<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="PT" style="font-size:10.5pt;font-family:Consolas;color:#1f497d">CTE2/Tecnologias e Desenvolvimento<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:10.5pt;font-family:Consolas;color:#1f497d">PT Inovação<u></u><u></u></span></p>
</div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p></div></div><br>_______________________________________________<br>
scap-security-guide mailing list<br>
<a href="mailto:scap-security-guide@lists.fedorahosted.org">scap-security-guide@lists.fedorahosted.org</a><br>
<a href="https://lists.fedorahosted.org/mailman/listinfo/scap-security-guide" target="_blank">https://lists.fedorahosted.org/mailman/listinfo/scap-security-guide</a><br>
<br></blockquote></div><br></div>