[PATCH] [RHEL/6, RHEL/7, shared] Finish logrotate_rotate_all_files => ensure_logrotate_activated transition. Replace ensure_logrotate_activated unknown test stub with actual OVAL check implementation.

Jan Lieskovsky jlieskov at redhat.com
Fri May 30 09:09:51 UTC 2014


The change:
  [1] https://git.fedorahosted.org/cgit/scap-security-guide.git/commit/?id=d2f99b0bd6dab889c5e023cf4df90df8bab8bc33

attempted to replace "logrotate_rotate_all_files" OVAL check with "ensure_logrotate_activated" OVAL check,
but failed (to do so in all locations):

  scap-security-guide]$ grep -rHn "logrotate_rotate_all_files" *
  RHEL/6/input/system/logging.xml:377:<oval id="logrotate_rotate_all_files" />
  RHEL/7/input/system/logging.xml:377:<oval id="logrotate_rotate_all_files" />

resulting into the following new 'make validate' / verify-input-references.py error message to appear:
  Invalid OVAL definition referenced by XCCDF Rule: ensure_logrotate_activated

Fix that by referencing the new OVAL check name in RHEL/{6,7}/input/system/logging.xml files too.

Besides that the original RHEL/6/input/checks/ensure_logrotate_activated.xml OVAL check was implemented just
as unknown OVAL test stub. Replace that stub definition with actual implementation based on guide.html content,
move it to shared, and create links for RHEL/6 and RHEL/7.

The proposal has been tested on RHEL/6 & RHEL/7 - rpm package builds properly, make validate warning
disappeared & the check seems to be working properly on both of the products.

Please review.

Thank you && Regards, Jan.
--
Jan iankko Lieskovsky / Red Hat Security Technologies Team
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-RHEL-6-RHEL-7-shared-Finish-logrotate_rotate_all_fil.patch
Type: text/x-patch
Size: 6281 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/scap-security-guide/attachments/20140530/26e0e4ac/attachment.bin>


More information about the scap-security-guide mailing list