[PATCH 2/2] fixed pattern in accounts_max_concurrent_login_sessions

Paul Tittle (Contractor) ptittle at cmf.nrl.navy.mil
Tue May 20 12:38:45 UTC 2014


Thank you for the ack, Andrew. Pushed.

On 5/19/14 5:11 PM, Andrew Gilmore wrote:
> If this is accepted syntax for our checks, then so be it. Do you have a
> preference? If you are comfortable with your patch as submitted, then
> consider it ack'd.
>
>
> On a separate note, I'm getting mail loop errors sending to the list, but
> then my emails seem to be getting through?
>
>
>
> This is the mail system at host lists.fedorahosted.org.
>> I'm sorry to have to inform you that your message could not
>> be delivered to one or more recipients. It's attached below.
>>
>> For further assistance, please send mail to postmaster.
>>
>> If you do so, please include this problem report. You can
>> delete your own text from the attached returned message.
>>
>>                     The mail system
>>
>> <scap-security-guide at lists.fedorahosted.org>: mail forwarding loop for
>>      scap-security-guide at lists.fedorahosted.org
>>
>> Final-Recipient: rfc822; scap-security-guide at lists.fedorahosted.org
>> Action: failed
>> Status: 5.4.6
>> Diagnostic-Code: X-Postfix; mail forwarding loop for
>>      scap-security-guide at lists.fedorahosted.org
>>
>
>
>
> On Mon, May 19, 2014 at 2:00 PM, Paul Tittle (Contractor) <
> ptittle at cmf.nrl.navy.mil> wrote:
>
>>   That's good to know. I just cribbed off of the way the pam matching
>> patterns did it. For example:
>>
>> <ind:pattern operation="pattern
>> match">^\s*auth\s+(?:(?:sufficient)|(?:\[default=die\]))\s+pam_faillock\.so.*deny=([0-9]*).*$</ind:pattern>
>>
>>
>> On 5/19/14 3:53 PM, Andrew Gilmore wrote:
>>
>> NACK on nit-picky RE issues...
>>
>> I believe it is sufficient to only make the surrounding subpattern
>> non-matchable...
>> (?:hard|-)
>> instead of
>> (?:(?:hard)|(?:-))
>>
>> I actually had success with no subpattern at all:
>> hard|-
>> but I'm not clear why.
>>
>> Good catch though, I was about to put my patch for this one up. :)
>>
>> On Mon, May 19, 2014 at 1:44 PM, Paul Tittle <ptittle at cmf.nrl.navy.mil> <ptittle at cmf.nrl.navy.mil>wrote:
>>
>>
>>   ---
>>   .../accounts_max_concurrent_login_sessions.xml     |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git
>> a/RHEL/6/input/checks/accounts_max_concurrent_login_sessions.xml
>> b/RHEL/6/input/checks/accounts_max_concurrent_login_sessions.xml
>> index b08faa5..868c58e 100644
>> --- a/RHEL/6/input/checks/accounts_max_concurrent_login_sessions.xml
>> +++ b/RHEL/6/input/checks/accounts_max_concurrent_login_sessions.xml
>> @@ -21,7 +21,7 @@
>>
>>     <ind:textfilecontent54_object
>> id="object_etc_security_limits_conf_maxlogins" version="1">
>>       <ind:filepath>/etc/security/limits.conf</ind:filepath>
>> -    <ind:pattern operation="pattern
>> match">^[\s]*\*[\s]+[hard|-][\s]+maxlogins[\s]+(\d+)\s*$</ind:pattern>
>> +    <ind:pattern operation="pattern
>> match">^[\s]*\*[\s]+(?:(?:hard)|(?:-))[\s]+maxlogins[\s]+(\d+)\s*$</ind:pattern>
>>       <ind:instance datatype="int">1</ind:instance>
>>     </ind:textfilecontent54_object>
>>
>> --
>> 1.7.1
>>
>> _______________________________________________
>> scap-security-guide mailing listscap-security-guide at lists.fedorahosted.orghttps://lists.fedorahosted.org/mailman/listinfo/scap-security-guide
>>
>>
>>
>> _______________________________________________
>> scap-security-guide mailing listscap-security-guide at lists.fedorahosted.orghttps://lists.fedorahosted.org/mailman/listinfo/scap-security-guide
>>
>>
>>
>> _______________________________________________
>> scap-security-guide mailing list
>> scap-security-guide at lists.fedorahosted.org
>> https://lists.fedorahosted.org/mailman/listinfo/scap-security-guide
>>
>>
>
>
> _______________________________________________
> scap-security-guide mailing list
> scap-security-guide at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/scap-security-guide

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/scap-security-guide/attachments/20140520/f141dec9/attachment-0001.html>


More information about the scap-security-guide mailing list