[PATCH 0/2] Remove unused, redundant package_vsftpd_installed.xml check

Shawn Wells shawn at redhat.com
Tue Mar 25 03:32:53 UTC 2014


On 3/24/14, 2:13 PM, Maura Dailey wrote:
> This check isn't referenced anywhere and should be removed. It is safe to do so because the existing check package_vsftpd_removed.xml provides the same functionality and more closely reflects the desired final state of the system.
>
> - Maura Dailey
>
> Maura Dailey (2):
>    This deletes an unnecessary check. package_vsftpd_removed is the
>      check that is actually referenced in other OVAL definitions.
>    vsftpd should not be in packages_installed.csv.
>
>   RHEL/6/input/checks/package_vsftpd_installed.xml   |   26 --------------------
>   .../input/checks/templates/packages_installed.csv  |    1 -
>   2 files changed, 0 insertions(+), 27 deletions(-)
>   delete mode 100644 RHEL/6/input/checks/package_vsftpd_installed.xml

Hmm.... ;)
>
> [shawn at SSG-RHEL6 templates]$ git blame packages_installed.csv
> ....
> ee53c824 RHEL6/input/checks/templates/packages_installed.csv (Maura 
> Dailey 2013-08-22 14:10:53 -0400 15) vsftpd
>


I've no idea why vsftpd would be declared in packages_installed. The 
service_vsftpd_disabled references package_vsftpd_removed. And you're 
right, no profiles call package_vsftpd_installed:
> [shawn at SSG-RHEL6 profiles]$ pwd
> /var/www/html/scap-security-guide/RHEL/6/input/profiles
> [shawn at SSG-RHEL6 profiles]$ grep -rin package_vsftpd_installed *


Ack.


More information about the scap-security-guide mailing list