[PATCH 3/4] Created remediation template

Shawn Wells shawn at redhat.com
Sun Jun 2 00:09:01 UTC 2013


On 6/1/13 7:01 PM, Jeffrey Blank wrote:
> NACK.  This is mostly just a copy of a file from another directory.
What are thoughts on creating a combined bash+OVAL RHEL6/templates 
directory? If things can have template OVAL, they should e able to have 
template bash as well. Might as well put everything together.



> Why is there code to handle packages?
>
Not sure why I didn't see that. Deleted:
> +        if packagename:
> +            filestring = filestring.replace("PACKAGENAME", packagename)
> +        else:
> +            filestring = re.sub("\n\s*<criteria.*>\n\s*<extend_definition.*/>", "", filestring)
> +            filestring = re.sub("\s*</criteria>\n\s*</criteria>", "\n    </criteria>", filestring)





More information about the scap-security-guide mailing list