[PATCH] Removing content of pattern match line, since it seems to break OVAL. Also, updated id names to be real words, not randomly generated values.

Jeffrey Blank blank at eclipse.ncsc.mil
Tue Jul 16 21:02:36 UTC 2013


Please push!

Now there's only one problem left in our OVAL schematron validation!


On 07/16/2013 02:44 PM, Maura Dailey wrote:
> At Jeff's request, I tested the following changes. It appears that the contents of the pattern check are not required and break
> OVAL validation.
> 
> - Maura Dailey
> 
> Signed-off-by: Maura Dailey <maura at eclipse.ncsc.mil>
> ---
>  RHEL6/input/checks/banner_etc_issue.xml |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/RHEL6/input/checks/banner_etc_issue.xml b/RHEL6/input/checks/banner_etc_issue.xml
> index 346bfab..e13bd3a 100644
> --- a/RHEL6/input/checks/banner_etc_issue.xml
> +++ b/RHEL6/input/checks/banner_etc_issue.xml
> @@ -8,15 +8,15 @@
>        <description>The system login banner text should be set correctly.</description>
>      </metadata>
>      <criteria>
> -      <criterion comment="/etc/issue is set appropriately" test_ref="test_20102" />
> +      <criterion comment="/etc/issue is set appropriately" test_ref="test_banner_etc_issue" />
>      </criteria>
>    </definition>
> -  <ind:textfilecontent54_test check="all" check_existence="all_exist" comment="correct banner in /etc/issue" id="test_20102" version="1">
> -    <ind:object object_ref="obj_20102" />
> +  <ind:textfilecontent54_test check="all" check_existence="all_exist" comment="correct banner in /etc/issue" id="test_banner_etc_issue" version="1">
> +    <ind:object object_ref="object_banner_etc_issue" />
>    </ind:textfilecontent54_test>
> -  <ind:textfilecontent54_object id="obj_20102" version="1">
> +  <ind:textfilecontent54_object id="object_banner_etc_issue" version="1">
>      <ind:filepath>/etc/issue</ind:filepath>
> -    <ind:pattern var_ref="login_banner_text" operation="pattern match">^.*(.+).*$</ind:pattern>
> +    <ind:pattern var_ref="login_banner_text" operation="pattern match" />
>      <ind:instance datatype="int" operation="greater than or equal">1</ind:instance>
>    </ind:textfilecontent54_object>
>    <external_variable comment="warning banner text variable" datatype="string" id="login_banner_text" version="1" />
> 


More information about the scap-security-guide mailing list