[PATCH] Commented out unreferenced check/value.

Michael Palmiotto mpalmiotto at tresys.com
Mon Jul 16 23:22:22 UTC 2012


>> +<!-- Check not referenced in any Rule
>> +     <select
>>idref="set_sysctl_net_ipv4_icmp_ignore_bogus_error_messages"
>>selected="true"/>
>> +-->

>> +<!-- Value not referenced in any Rules
>> +    <refine-value
>>idref="sysctl_net_ipv4_icmp_ignore_bogus_error_messages_value"
>>selector="enabled"/>
>> +-->

>>It's called out on
>>scap-security-guide/RHEL6/input/system/network/kernel.xml:295

>Consider me totally out of the loop at this point, and transforms might
>address this, but isn't this snippet for a different ID?
>Thanks
>--Spencer

I think you're actually both right and the blame lies in my court. 
Shawn was probably looking at the patch cover letter, while Spencer was
looking at the diff.

Let me clear this up.  The cover letter for my patch reflects the wrong 
idref (ie bogus_error_responses rather than bogus_error_messages). 
It was intended to say, "[PATCH] Commented out unreferenced 
sysctl_net_ipv4_icmp_ignore_bogus_error_messages check/value."

I am still not seeing the bogus_error_messages check/value being 
referenced in any Rules.

My apologies for the confusion.

-Mike


More information about the scap-security-guide mailing list