[PATCH] Added 'make rpm'

Spencer R. Shimko sshimko at tresys.com
Tue Apr 3 03:47:39 UTC 2012


Forgive the format issues but my mail client isn't playing nice tonight.

>          
>        On 4/2/12 1:31 PM, "Shawn Wells" <shawn at redhat.com>
><mailto:shawn at redhat.com>><mailto:shawn at redhat.com>
><mailto:shawn at redhat.com> wrote:
>>        
>          > >+rpm: dist
        >>        
>>        I'm not happy with assumptions regarding user environment.  We
>don't
>control rpmbuild or the RPM macros file.  Barring those issues this also
>makes some assumptions about directory structure that might not be
>correct.  
>      
>    
>>    
>    All valid. I wanted to get *something* in there that would work on a
>    stock RHEL6 build system.
>    
>    What I'd *really* like to see is input/rpmbuild be setup as a
>    localized buildroot which would allow us to be completely self
>    contained (and much more elegant). But I have no idea how to do that
>    and in mucking around it didn't become apparent to me. Hopefully
>    someone with more RPM knowledge than me could patch to make that
>    happen.

>> How about supporting both mock and plain RPM builds?  We have a build
>> system that does that internally that we can apply to this situation (we
>> are done with the fragility of build VMs).  But the caveat here is that
>>it
>> comes with some rather significant complexity.  Not auto make's level of
>> complexity, but perhaps unnecessary complexity for this project.
>>
>> A simpler approach that just handles RPM builds (no mock) can be found
>> here:
>> 
>>http://oss.tresys.com/projects/clip/browser/trunk/refpolicy/build/Makefil
>>e
>>    
>>
>>    
>   Read through your Makefile.... very clean. I've got no objections on
>    using mock, especially to create the SRPMs. And IMO there shouldn't
>    be much of a problem introducing complexity if it creates cleaner
>    output than we're otherwise capable of producing.
>    
>    Are you volunteering to clean up the Makefile, or should I take a
>    stab at it?

Yup sign me up :)  I'll submit a patch in the next day or two for the RPM
rolling outside of mock.  I'll submit an update that will support mock if
folks think it is worth the pain.

Thanks,
--Spencer
     
>    -- 
> Shawn Wells
> Technical Director,
> U.S. Intelligence Programs
> (e) shawn at redhat.com
> (c) 443.534.0130
  

_______________________________________________
scap-security-guide mailing list
scap-security-guide at lists.fedorahosted.orghttps://fedorahosted.org/mailman/
listinfo/scap-security-guide



More information about the scap-security-guide mailing list