using ${} notation in ant recipe

Charles Crouch ccrouch at redhat.com
Wed Jun 30 15:28:30 UTC 2010


Ian
Can we make sure we have a BZ for this, so we can make sure it gets QA's

Thanks
Charles
----- "Ian Springer" <ian.springer at redhat.com> wrote:

> This should now be fixed in the release-3.0.0 branch:
> 
> 10:54:56.085: git commit --only -F 
> /tmp/git-comit-msg-1754503874713002688.txt -- 
> modules/plugins/ant-bundle/src/test/java/org/rhq/plugins/ant/AntBundlePluginComponentTest.java
> 
> modules/common/ant-bundle/src/main/java/org/rhq/bundle/ant/BundleAntProject.java
> 
> modules/common/ant-bundle/src/main/java/org/rhq/bundle/ant/AntLauncher.java
> 
> modules/plugins/ant-bundle/src/test/resources/test-bundle.xml 
> modules/common/ant-bundle/src/main/java/org/rhq/bundle/ant/type/InputPropertyType.java
> 
> modules/common/ant-bundle/src/main/java/org/rhq/bundle/ant/task/BundleTask.java
> [release-3.0.0 85bdf62] make sure that the rhq:inputProperty element 
> sets the default value on the corresponding project property during
> the 
> configuration, and not the execution, of the rhq:bundle task; that
> way, 
> the other child elements of the rhq:bundle task can reference the
> input 
> property via ${inputProp} and know that it will be initialized to its
> 
> default value, if it had one; add validation of input properties 
> according to their specified type
>   6 files changed, 218 insertions(+), 149 deletions(-)
> 10:54:57.208: git push -v origin 
> refs/heads/release-3.0.0:refs/heads/release-3.0.0
> Pushing to ssh://git.fedorahosted.org/git/rhq/rhq.git
> To ssh://git.fedorahosted.org/git/rhq/rhq.git
>     584b2d4..85bdf62  release-3.0.0 -> release-3.0.0
> 
> On 06/29/2010 07:34 PM, Ian Springer wrote:
> > Yeah, this is a bug. I'm working on it - should have a fix in at
> some
> > point tomorrow morning.
> >
> > On 06/29/2010 09:31 AM, John Mazzitelli wrote:
> >    
> >> shashin from #rhq has this question - I haven't tried this, but
> this
> >> should work. If it doesn't, we should try to fix it so it does
> work.
> >> This would be an important feature:
> >>
> >> In deploy.xml ant recipe, define this:
> >>
> >> <rhq:input-property name="profile.template"
> >>       description="Name of JBoss EAP template used to create
> Profile"
> >>       required="true"
> >>       defaultValue="default"
> >>       type="string"/>
> >>
> >> Now, inside of the<rhq:deployment-unit>   task, define an rhq:file
> >> definition, and use that input property in the value of the name
> >> attribute, like this:
> >>
> >> <rhq:deployment-unit ...>
> >> ...
> >>       <rhq:file name="eap-template-${profile.template}-50.zip" />
> >>
> >> Our ant handler should replace all ${} variables with their
> property
> >> values (whether they were defined with rhq:input-property or just
> the
> >> normal Ant<property>.
> >>
> >> Its been reporting that this doesn't work. Can someone confirm that
> this
> >> is broken? If so, we need to write up a bugzilla and hopefully fix
> this.
> >> _______________________________________________
> >> rhq-users mailing list
> >> rhq-users at lists.fedorahosted.org
> >> https://fedorahosted.org/mailman/listinfo/rhq-users
> >>
> >>      
> >
> >    
> 
> 
> -- 
> Ian Springer
> Sr. Software Developer
> JBoss Operations Network
> Red Hat
> ian.springer at redhat.com
> 
> _______________________________________________
> rhq-users mailing list
> rhq-users at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/rhq-users


More information about the rhq-users mailing list