[rhq-metrics] False positives on Javascript license checks

mike thompson mithomps at redhat.com
Fri Jan 30 21:37:33 UTC 2015


These *.js and *.map files should not be checked for license (think of them as compiled binary output and not checked in). All of our projects are typescript (*.ts) projects which is where the license checking should occur. The *.js and *.map files are compiled output from the typescript compiler. The .map files are debugging files (sourcemaps) used by the browser to allow debugging in the source language such as typescript.

So the license checker should look at *.ts files and look for /// comments that typescript doesn’t compile to js. Tsegismont went through and added the license headers in a while back.

[INFO] --- license-maven-plugin:2.7:check (default) @ explorer ---
[INFO] Checking licenses...
[WARNING] Unknown file extension: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/app.js.map
[WARNING] Unknown file extension: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/controllers/chart-controller.js.map
[WARNING] Unknown file extension: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/controllers/config-controller.js.map
[WARNING] Unknown file extension: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/controllers/insert-metrics-controller.js.map
[WARNING] Unknown file extension: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/controllers/metric-overlay-controller.js.map
[WARNING] Unknown file extension: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/directives/date-time-range-selection-directive.js.map
[WARNING] Unknown file extension: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/directives/enter-key-directive.js.map
[WARNING] Unknown file extension: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/services/metric-data-service.js.map
[WARNING] Missing header in: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/controllers/insert-metrics-controller.js
[WARNING] Missing header in: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/controllers/config-controller.js
[WARNING] Missing header in: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/controllers/chart-controller.js
[WARNING] Missing header in: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/app.js
[WARNING] Missing header in: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/directives/enter-key-directive.js
[WARNING] Missing header in: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/controllers/metric-overlay-controller.js
[WARNING] Missing header in: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/services/metric-data-service.js
[WARNING] Missing header in: /Users/mtho11/projects/rhq-metrics/ui/explorer/src/main/webapp/scripts/directives/date-time-range-selection-directive.js


More information about the rhq-devel mailing list