[rhq.next] Using assert-j in tests

Peter Palaga ppalaga at redhat.com
Tue Dec 2 13:23:43 UTC 2014


On 2014-12-02 10:34, Thomas Segismont wrote:
> Look at the parent POM, mockito has the "test" scope:
> https://github.com/joel-costigliola/assertj-maven-parent-pom/blob/master/pom.xml

Indeed. I have no other concerns. -- P

> We didn't have any "default" mocking lib for RHQ, AFAIK. I do prefer
> Mockito other alternatives.
>
> Le 02/12/2014 10:27, Peter Palaga a écrit :
>> Hi *, I see mockito [1] (among others) in assertj deps. Is hereby
>> Mockito becoming our preferred mock lib? -- P
>>
>> [1]
>> https://github.com/joel-costigliola/assertj-core/blob/master/pom.xml#L36
>>
>> On 2014-12-02 10:09, Thomas Segismont wrote:
>>> Hi,
>>>
>>> Last week I submitted a PR "Rest test: don't rebuild rest war over and
>>> over again when Arquillian @Deployment method is executed" [1]
>>>
>>> As part of the changes, I added a new test dependency to assertj [2]
>>>
>>> Before the PR can be merged, do you all agree to use this? It's only a
>>> test dependency.
>>>
>>> Here's what I like:
>>>
>>> * write assertThat(testedObject) and then use code completion to find
>>> the method you need
>>>
>>> * nice fluent API
>>>
>>> ```
>>> WebArchive[] webArchives = ...;
>>> assertThat(webArchives).isNotNull().isNotEmpty().hasSize(1);
>>> ```
>>>
>>> This reads much better IMO that the equivalent with base
>>> assertNull/assertFalse/assertEquals
>>>
>>>
>>> There's a good descriptions of features on the project site [2].
>>>
>>> Regards,
>>> Thomas
>>>
>>>
>>> [1] https://github.com/rhq-project/rhq-metrics/pull/72
>>> [2]
>>> http://joel-costigliola.github.io/assertj/assertj-core-features-highlight.html
>>>
>>>
>>>
>>> _______________________________________________
>>> rhq-devel mailing list
>>> rhq-devel at lists.fedorahosted.org
>>> https://lists.fedorahosted.org/mailman/listinfo/rhq-devel
>>
>> _______________________________________________
>> rhq-devel mailing list
>> rhq-devel at lists.fedorahosted.org
>> https://lists.fedorahosted.org/mailman/listinfo/rhq-devel
>
> _______________________________________________
> rhq-devel mailing list
> rhq-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/rhq-devel



More information about the rhq-devel mailing list