Fwd: AS7Plugin: upload connection with httpclient

Thomas Segismont tsegismo at redhat.com
Thu Jan 3 14:17:28 UTC 2013


Hi,

I'm forwarding this to the list in case anybody has any comment.

Cheers
Thomas Segismont

-------- Message original --------
Sujet: AS7Plugin: upload connection with httpclient
Date : Thu, 03 Jan 2013 12:30:27 +0100
De : Thomas Segismont <tsegismo at redhat.com>
Pour : ON Team <jboss-on-team at redhat.com>

Hi all,

As a fix for BZ 887320, I have refactored ASUploadConnection so that it
now uses httpclient as communication layer with AS7 http management
interface.

The change is in branch tsegismont/as7plugin-httpclient and here are the
contents:
* Added a commons-httpclient.version property to the root POM
The same httpclient version was hard-coded in various sub projects
* Added commons-httpclient and commons-codec (needed by httpclient) as
dependencies of AS7 plugin
* Change ASUploadConnection implementation
The new implementation has minor API modifications. I changed the code
accordingly in our source tree but it could be a problem if a plugin
developer uses this class (simple call or class extension).

I had trouble to run integration tests on my machine so I made some
extra modifications:
* Changed ANT script for AS7 download and install
This script, embedded in the plugin POM, was not working for all
versions of AS7 (community/eap, release/snapshot). I made it generic
(needed to upgrade ANT version to latest).

Additionally, I found that in Arquillian integration project we had a
class (SigarInstaller) relying on an hard-coded version of the Sigar
dist artifact so I also fixed that.

Eventually, I was not able to run the integration tests locally (it
seems related to the way Arquillian resolve Maven artifacts, it doesn't
use my local repo).

Still, all integration tests passed when I used the rhq-probe job on
Jenkins (I added as7.itest as an active profile).

Can someone please review the code in this branch before I put it into
master?

Thanks and regards
Thomas






More information about the rhq-devel mailing list