BZ 783603 - async measurement collection - can someone peer review and/or test?

John Sanda jsanda at redhat.com
Tue Feb 26 16:18:36 UTC 2013


I have only looked at the patches briefly so far. I know we do something similar for availability, but I am  -1 on this approach (same goes for availability). I am all for providing a way to make it async, but force the implementation details into each plugin resource component. Managing thread pools should be handled by the PC. And if it is done by the PC there is no need for the logic to be duplicated across plugins.

If we want to support collecting metrics asynchronously then I think we should think about doing it in a way that just reuses MeasurementFacet.getValues(MeasurementReport report, Set<MeasurementScheduleRequest> metrics).

On Feb 26, 2013, at 10:18 AM, John Mazzitelli <mazz at redhat.com> wrote:

> I have some time today so I am revisiting this. This involves a community contribution that adds a plugin API allowing metric collections to be asynchronously collected.
> 
> I am going to see if I can merge BZ 783603 into master (see links below in my earlier email). First, I will make sure all tests pass (there are some unit tests surrounding this).
> 
> ----- Forwarded Message -----
> From: "John Mazzitelli" <mazz at redhat.com>
> To: "rhq-devel" <rhq-devel at lists.fedorahosted.org>
> Sent: Tuesday, October 16, 2012 10:03:54 AM
> Subject: BZ 783603 - async measurement collection - can someone peer review and/or test?
> 
> There is a community contribution to the agent plugin container allowing for async measurement collection:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=783603
> 
> I created a branch off of master and put the patches for this enhancement in it:
> 
> http://git.fedorahosted.org/cgit/rhq/rhq.git/log/?h=bug/783603
> 
> In order to be merged into master and get into the next RHQ release, we need someone to peer review this and test this. Is anyone available?
> 
> Looking at the new code, it appears we do have unit tests for this.
> _______________________________________________
> rhq-devel mailing list
> rhq-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/rhq-devel



More information about the rhq-devel mailing list