Building with maven 3.0.4 and JDK 1.7 (current state)

Heiko W.Rupp hrupp at redhat.com
Wed Jul 11 11:55:54 UTC 2012


Mazz,

Am 10.07.2012 um 21:15 schrieb John Mazzitelli:

> All those testPrintyPrint... ones I think you hit several weeks ago. Back then, I mentioned those had to do with i18N messages and I think you then said that you might have ran those tests on locales that we didn't have translations for (???) I can't remember the details, all I remember was you mentioning this

Indeed it is this piece of code:

org.rhq.enterprise.server.alert.test.AlertManagerBeanTest#extractCondition

prettyString=
- Bedingung 1: Operation [opNameHere] has status=[FAILURE]
- Datum/Uhrzeit: 2012/07/11 09:12:26 MESZ
  - Details: null
pattern=
 - Cond(?:ition)? 1: (.*)

And then (when this is solved) 
      pretty = getShortPrettyAlertConditionString(condition);
      assert "Foo Prop Between 1.0B - 22.2B, incl".equals(pretty)

Where in all cases some English version is hard coded

I have changed that now and pushed the change to master.

For the Failover list issues, the BZ is https://bugzilla.redhat.com/show_bug.cgi?id=839256

> before, and after I said it had to do with i18n it seems a light bulb went off in your head and you knew what the problem was (but I don't know what it was :)
> 
> ----- Original Message -----
>> Hi,
>> 
>> I am currently looking into building RHQ with OpenJDK 1.7(*) and mvn
>> 3.0.4 on RHEL 6.3
>> I see these issues:
>> 
>> - animal sniffer can't cope with the groovy-script-server-plugin (and
>> 1.7 seems to have a bug wrt maven 3 anyway)
>> -
>> doNotSendEmptyZipFileToServer(org.rhq.core.pc.drift.DriftFilesSenderTest)
>> fails ( https://bugzilla.redhat.com/show_bug.cgi?id=838681 )
>> 
>> Failing tests in server/jar:
>> Failed tests:
>>  testGetForAllAgents20_1000(org.rhq.enterprise.server.cloud.FailoverListManagerBeanTest)
>>  testGetForAllAgents5_10(org.rhq.enterprise.server.cloud.FailoverListManagerBeanTest)
>>  testGetForAllAgents5_25(org.rhq.enterprise.server.cloud.FailoverListManagerBeanTest)
>> 
>> Those are failing because the distributions of agents on servers is
>> not even (on the 5/10 test, on server has 3 agents
>> and another one has 1 instead of the 2/2 one).
>> 
>> 
>>  testPrettyPrintDRIFT(org.rhq.enterprise.server.alert.test.AlertManagerBeanTest):
>>  could not find the condition string
>>  testPrettyPrintAVAILABILITY_DURATION(org.rhq.enterprise.server.alert.test.AlertManagerBeanTest):
>>  could not find the condition string
>>  testPrettyPrintTHRESHOLD(org.rhq.enterprise.server.alert.test.AlertManagerBeanTest):
>>  could not find the condition string
>>  testPrettyPrintAVAILABILITY(org.rhq.enterprise.server.alert.test.AlertManagerBeanTest):
>>  could not find the condition string
>>  testPrettyPrintCONTROL(org.rhq.enterprise.server.alert.test.AlertManagerBeanTest):
>>  could not find the condition string
>>  testPrettyPrintBASELINE(org.rhq.enterprise.server.alert.test.AlertManagerBeanTest):
>>  could not find the condition string
>>  testPrettyPrintCHANGE(org.rhq.enterprise.server.alert.test.AlertManagerBeanTest):
>>  could not find the condition string
>>  testPrettyPrintCHANGE_Calltime(org.rhq.enterprise.server.alert.test.AlertManagerBeanTest):
>>  could not find the condition string
>>  testPrettyPrintTHRESHOLD_Calltime(org.rhq.enterprise.server.alert.test.AlertManagerBeanTest):
>>  could not find the condition string
>>  testPrettyPrintRESOURCECONFIG(org.rhq.enterprise.server.alert.test.AlertManagerBeanTest):
>>  could not find the condition string
>>  testPrettyPrintTRAIT(org.rhq.enterprise.server.alert.test.AlertManagerBeanTest):
>>  could not find the condition string
>>  testPrettyPrintEVENT(org.rhq.enterprise.server.alert.test.AlertManagerBeanTest):
>>  could not find the condition string
>>  testPrettyPrintRANGE(org.rhq.enterprise.server.alert.test.AlertManagerBeanTest):
>>  could not find the condition string
>> 
>> Those all seem to fail in AlertManager when doing
>> condition.getAlertDefintion().xxx as the alertDefinition is null on
>> the condition,
>> which is called within AlertManagerBean.prettyPrintAlertConditions(),
>> which is called from
>> org.rhq.enterprise.server.alert.test.AlertManagerBeanTest#getPrettyAlertConditionString
>> 
>> 
>> Server tests leave the database in an unclean state. The following
>> entries in the plugins table are still there
>> 
>> 'PluginManagerBeanTestPlugin1',
>> '/im/rhq/modules/enterprise/server/jar/target/test-classes/org/rhq/enterprise/server/resource/metadata//test-plugin1.jar'
>> 'PluginManagerBeanTestPlugin2',
>> '/im/rhq/modules/enterprise/server/jar/target/test-classes/org/rhq/enterprise/server/resource/metadata//test-plugin2.jar'
>> 'TestPlugin',
>> '/im/rhq/modules/enterprise/server/jar/target/test-classes/org/rhq/enterprise/server/resource/metadata//test-plugin.jar.jar'
>> 'PluginManagerBeanTestPlugin3',
>> '/im/rhq/modules/enterprise/server/jar/target/test-classes/org/rhq/enterprise/server/resource/metadata//test-plugin3.jar'
>> 
>> Which cause test inconsistencies when re-running tests.
>> 
>> 
>> I will open BZs
>> 
>> Just a note: to get the full test running, the dbuser (rhqadmin by
>> default) needs to have the right to create databases
>> which can be achieved via
>> postgres=# alter role rhqadmin with createdb;
>> ALTER ROLE
>> 
>> 
>> *) For the time being we will constrain ourselves to JDK 1.6 language
>> features.
>> --
>> Reg. Adresse: Red Hat GmbH, Technopark II, Haus C,
>> Werner-von-Siemens-Ring 14, D-85630 Grasbrunn
>> Handelsregister: Amtsgericht München HRB 153243
>> Geschaeftsführer:  Mark Hegarty, Charlie Peters, Michael Cunningham,
>> Charles Cachera
>> 
>> _______________________________________________
>> rhq-devel mailing list
>> rhq-devel at lists.fedorahosted.org
>> https://fedorahosted.org/mailman/listinfo/rhq-devel
>> 
> _______________________________________________
> rhq-devel mailing list
> rhq-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/rhq-devel

-- 
Reg. Adresse: Red Hat GmbH, Technopark II, Haus C, 
Werner-von-Siemens-Ring 14, D-85630 Grasbrunn
Handelsregister: Amtsgericht München HRB 153243
Geschaeftsführer:  Mark Hegarty, Charlie Peters, Michael Cunningham, Charles Cachera



More information about the rhq-devel mailing list