On-Demand Service Discovery Scans

Lukas Krejci lkrejci at redhat.com
Tue Aug 7 08:35:36 UTC 2012


I don't think we allow the plugins to access the InventoryReport class.
See http://git.fedorahosted.org/cgit/rhq/rhq.git/tree/modules/core/plugin-container/src/main/java/org/rhq/core/pc/PluginContainerConfiguration.java#n990

----- Original Message -----
> From: "Stefan Negrea" <snegrea at redhat.com>
> To: rhq-devel at lists.fedorahosted.org
> Sent: Tuesday, August 7, 2012 4:19:09 AM
> Subject: Re: On-Demand Service Discovery Scans
> 
> 
> 
> ----- Original Message -----
> > From: "Jay Shaughnessy" <jshaughn at redhat.com>
> > To: rhq-devel at lists.fedorahosted.org
> > Sent: Monday, August 6, 2012 3:09:23 PM
> > Subject: Re: On-Demand Service Discovery Scans
> > 
> > 
> > On 8/6/2012 2:49 PM, Heiko W.Rupp wrote:
> > > Hey,
> > >
> > > I think discoverChildResources() should be renamed
> > > to something along 'triggerChildResourceDiscovery()' in order to
> > > indicate that this
> > +1.  For consistency with AvailabilityContext and to intone that
> > component code doesn't really tell the PC what to do, I suggest:
> > 
> >    requestChildResourceDiscovery()
> > 
> > Also, I'd like to see more jdoc for this in the Interface,
> > describing
> > not just what it does but why/when it should be called by the
> > component
> > code.
> > 
> > Also the jdoc for getInventoryContext() doesn't read correctly and
> > has a
> > typo.
> > 
> 
> Thanks for the feedback. I updated the method name and also added
> documentation.
> 
> Commit with all these changes:
> http://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?h=stefan/inventorycontext&id=2b17808e9bff072776c7ecada992d33c34203155
> 
> 
> > > is no synchronous call, but that this will just happen as soon as
> > > possible.
> > >
> > > Otherwise it looks good to me.
> > >
> > > I wonder if it would make sense to implement a synchronous
> > > counterpart.
> > > First and foremost for testing purposes, but I can imagine that
> > > some plugin
> > > code could also use that for more sophisticated workflows.
> > >
> > 
> > 
> > _______________________________________________
> > rhq-devel mailing list
> > rhq-devel at lists.fedorahosted.org
> > https://lists.fedorahosted.org/mailman/listinfo/rhq-devel
> > 
> _______________________________________________
> rhq-devel mailing list
> rhq-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/rhq-devel
> 


More information about the rhq-devel mailing list