[rhq] modules/enterprise

mike thompson mithomps at fedoraproject.org
Thu Aug 2 13:40:05 UTC 2012


 modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/common/detail/operation/schedule/AbstractOperationScheduleDetailsView.java |   15 ++++------
 1 file changed, 7 insertions(+), 8 deletions(-)

New commits:
commit 63b805d29a7b66593203de5a006770adab06e105
Author: Mike Thompson <mithomps at redhat.com>
Date:   Wed Aug 1 20:00:29 2012 -0700

    [BZ 838665 - Changing selected operation does not clear out parameters sent along with request]

diff --git a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/common/detail/operation/schedule/AbstractOperationScheduleDetailsView.java b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/common/detail/operation/schedule/AbstractOperationScheduleDetailsView.java
index c52eb30..8b26cb2 100644
--- a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/common/detail/operation/schedule/AbstractOperationScheduleDetailsView.java
+++ b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/common/detail/operation/schedule/AbstractOperationScheduleDetailsView.java
@@ -193,6 +193,8 @@ public abstract class AbstractOperationScheduleDetailsView extends
         operationNameItem.setShowTitle(true);
         items.add(operationNameItem);
         operationNameItem.addChangedHandler(new ChangedHandler() {
+
+            @Override
             public void onChanged(ChangedEvent event) {
                 handleOperationNameChange();
             }
@@ -423,18 +425,15 @@ public abstract class AbstractOperationScheduleDetailsView extends
     private void refreshOperationParametersItem() {
         String operationName = getSelectedOperationName();
         String value;
+        operationParameters = null; // reset params between dropdown selects
+        // make sure we wipe out anything left by the previous op def
+        for (Canvas child : this.operationParametersConfigurationHolder.getChildren()) {
+            child.destroy();
+        }
         if (operationName == null) {
             value = "<i>" + MSG.view_operationScheduleDetails_fieldDefault_parameters() + "</i>";
-            for (Canvas child : this.operationParametersConfigurationHolder.getChildren()) {
-                child.destroy();
-            }
             this.operationParametersConfigurationHolder.hide();
         } else {
-            // make sure we wipe out anything left by the previous op def
-            for (Canvas child : this.operationParametersConfigurationHolder.getChildren()) {
-                child.destroy();
-            }
-
             final ConfigurationDefinition parametersDefinition = this.operationNameToParametersDefinitionMap
                 .get(operationName);
             if (parametersDefinition == null || parametersDefinition.getPropertyDefinitions().isEmpty()) {




More information about the rhq-commits mailing list