[python-bugzilla] Expanding Support for ExternalBugs

Brian Bouterse bbouters at redhat.com
Wed Mar 25 19:26:40 UTC 2015


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Thanks for the info. I just submitted my patch as described in
HACKING. It includes:

* Explicit keyword params for the function signatures.
* A new update_external_tracker method
* The rest of the params that add and remove support
* I extended build_external_tracker_boolean_query to support all the
params
* I rewrote the functional tests for add/update/remove and also the
query support. I added a lot of assertions (this took the longest).

Feel free to send feedback, adjustments, or merge it in! If it gets
merged can someone let me know? It's my first patch so I'm not sure if
I'll get notified.

Unrelated to my tests some of the rw_functional tests are broken. I
think one is due to my user not having enough perms (which I don't
need), but the second (tests.rw_functional.RHPartnerTest) looks like a
legitimate failure. See the failures here:
http://fpaste.org/202891/14273114/

I don't plan on fixing those, but someone should.

- -Brian


On 03/11/2015 09:56 AM, Arun Babu Neelicattu wrote:
> 
> 
> On Wed, Mar 11, 2015 at 7:17 AM Brian Bouterse
> <bbouters at redhat.com <mailto:bbouters at redhat.com>> wrote:
> 
> I'm using the ExternalBugs support in python-bugzilla from
> checkout. I can create and remove entries so that is good. Mainly
> I'm using the limited support from [0] which is a great start, but
> I need to set more of the attributes described here [1].
> 
> Specifically I want to do two things:
> 
> 1) Adjust the signature of add_external_bug and remove_external_bug
> to use keyword args to support all fields
> 
> 
> 
> 
> 2) Add a new update_external_bug method which accepts kwargs
> similar to how add and remove do
> 
> 
>> I reckon both are good ideas - assuming you mean tacking on a
>> **kwargs to the end of each methods; was a bit lazy with the
>> initial implementation and only did what was then required. :)
>> However, I do think it might be better to be explicit about the
>> args. Just my 2c.
> 
> 
> 
> I think I see how to do it for my own purposes. My question is how 
> could I contribute a patch back to be included in future 
> python-bugzilla releases? I couldn't find any documented process,
> so how do I contribute back?
> 
> 
>> I have submitted a patch [1] updating the HACKING text file to
>> include this detail. The crux of it is - send it to the list
>> using git-send-email :)
> 
>> Hope that helps.
> 
>> -arun
> 
>> [1]
>> https://lists.fedorahosted.org/pipermail/python-bugzilla/2015-March/000381.html
>
>> 
> 
> 
> [0]: 
> https://git.fedorahosted.org/__cgit/python-bugzilla.git/__commit/?id=__8edea7ec964924392fd889819af6cd__d619809413
>
> 
<https://git.fedorahosted.org/cgit/python-bugzilla.git/commit/?id=8edea7ec964924392fd889819af6cdd619809413>
> [1]: 
> https://bugzilla.redhat.com/__docs/en/html/api/extensions/__ExternalBugs/lib/WebService.__html
>
> 
<https://bugzilla.redhat.com/docs/en/html/api/extensions/ExternalBugs/lib/WebService.html>
> 
> -Brian _________________________________________________ 
> python-bugzilla mailing list 
> python-bugzilla at lists.__fedorahosted.org 
> <mailto:python-bugzilla at lists.fedorahosted.org> 
> https://lists.fedorahosted.__org/mailman/listinfo/python-__bugzilla
>
> 
<https://lists.fedorahosted.org/mailman/listinfo/python-bugzilla>
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJVEwvwAAoJEK48cdELyEfyGEgH/3J73RnTurGphUSpu5wiU4d7
hZXlk6AuVxHw6HPQGQGEssqhrWMVehZpfYmAOVb0XhYKWTubW0rxzKEGt7IXnMKO
4spmKbj11dkT+9/QstnFsB17a6KWfav38pWEPHIrHHd2GFdmcw9kCKLht8EAjmAt
Ny9Kkc05x8pDJgZypDsqgd/YZAt9JxRg3wo5LXDPe+szAbcCX9fJIZuncqOfdQPd
IKSjI9/UboL1Wn3UQxDvCg6zW02fhWhQJu36QRXcKsC8jPU2mYrw/Rfo3bxYDUWp
ejjweWU3PuIwO+kO0REQbgqxF3lBoQ7DlCuZ20dcDy/rRitiXdIsVLahUV/BmXg=
=edo8
-----END PGP SIGNATURE-----


More information about the python-bugzilla mailing list