[python-bugzilla] Refactoring login logic

Cole Robinson crobinso at redhat.com
Sat Sep 27 12:36:39 UTC 2014


On 09/27/2014 02:47 AM, Arun Babu Neelicattu (Red Hat) wrote:
> Hi,
> 
> One of the annoyances I have had using python-bugzilla in projects has
> been the need to copy-paste the login logic w/ token/cookie awareness.
> 
> To address this, I'd like to refactor the login logic from the cli
> code into bugzilla.util, for which changes might look something like
> [1]. This might not be the final version, I am open to suggestions.
> 
> Is this something that would be considered useful for other users?
> 
> -arun
> 

Sounds good to me, but I'd prefer:

- Just add it to the BugzillaBase class. Saves creating the extra file, the
getLogger hack, and it takes a Bugzilla instance anyways. Maybe name it
interactive_login or something.

- Expand the docstring a bit to describe what it does and what the parameters are.

Thanks,
Cole


More information about the python-bugzilla mailing list