[python-bugzilla] requests dependency missing from setup.py/setup.cfg; bugzilla cli/modules fail to import on machines without requests package

Arun Babu Neelicattu abn at redhat.com
Sun Sep 14 22:26:23 UTC 2014


I'd prefer to use the initial implementation for this. The reason being that the requirement files can be more complex than just a list of requirements with comments [1]. It is easier to let the pip requirements parser handle all these intricacies than worry about keeping things up-to-date just to be future safe.

-arun

[1] http://pip.readthedocs.org/en/latest/reference/pip_install.html#requirements-file-format

----- Original Message -----
> From: "Pierre-Yves Chibon" <pingou at pingoured.fr>
> To: "Arun Babu Neelicattu" <abn at redhat.com>
> Cc: "Garrett Cooper" <yanegomi at gmail.com>, python-bugzilla at lists.fedorahosted.org
> Sent: Saturday, September 13, 2014 5:48:43 PM
> Subject: Re: [python-bugzilla] requests dependency missing from setup.py/setup.cfg; bugzilla cli/modules fail to
> import on machines without requests package
> 
> On Fri, Sep 12, 2014 at 03:04:31PM +1000, Arun Babu Neelicattu wrote:
> > 
> > 
> > On Thu, 2014-09-11 at 14:36 -0700, Garrett Cooper wrote:
> > > Hello!
> > >     I recently did a pip install of python-bugzilla, which installed
> > > 1.1.0, and when I tried running the bugzilla command it failed to
> > > execute because the requests module wasn't installed on my machine.
> > >     Replacing requirements.txt with the following lines in setup.py
> > >     should work:
> > > 
> > >     install_requires=[
> > >         'requests',
> > >     ]
> > > 
> > 
> > This might be the easiest fix for this. But this would mean we will have
> > to keep *requirements.txt in sync with setup.py (not too big a deal).
> > 
> > We could also do something like this,
> > https://github.com/abn/python-bugzilla/commit/b66ba937bbc182476d0d59d4fbdf36ae389783b6
> > (might be over kill considering we do not depend on much).
> 
> I just wanted to point out a possible other way to do it:
> https://github.com/fedora-infra/pkgdb2/blob/master/setup.py#L15
> 
> Pierre
> 


More information about the python-bugzilla mailing list