[python-bugzilla] requests dependency missing from setup.py/setup.cfg; bugzilla cli/modules fail to import on machines without requests package

Arun Babu Neelicattu abn at redhat.com
Fri Sep 12 05:04:31 UTC 2014



On Thu, 2014-09-11 at 14:36 -0700, Garrett Cooper wrote:
> Hello!
>     I recently did a pip install of python-bugzilla, which installed
> 1.1.0, and when I tried running the bugzilla command it failed to
> execute because the requests module wasn't installed on my machine.
>     Replacing requirements.txt with the following lines in setup.py should work:
> 
>     install_requires=[
>         'requests',
>     ]
> 

This might be the easiest fix for this. But this would mean we will have
to keep *requirements.txt in sync with setup.py (not too big a deal).

We could also do something like this,
https://github.com/abn/python-bugzilla/commit/b66ba937bbc182476d0d59d4fbdf36ae389783b6 (might be over kill considering we do not depend on much).

The only real reason why we use *requirements.txt is to allow for
setting up dev environments easily.

Neither of these changes should interfere with rpms. Not sure which is
preferred.

>     Also, if python-bugzilla depends on certain API versions of
> requests, it might be a good idea to do some sort of version checking;
> I know that the latest version of the requests package is not
> backwards compatible in many ways with the new one.

This was intentionally left out as there are no known issues with
backwards compatibility for the requests features we use, at least the
ones that gets used in the tests and using requests==2.4.1.

If we were to require a lower version bound, then requests>=1.1.0 might
be the one to use as this is the version shipped in epel-6 and this is
known to work.

hth

-arun

> Thanks!
> -Garrett
> _______________________________________________
> python-bugzilla mailing list
> python-bugzilla at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/python-bugzilla




More information about the python-bugzilla mailing list