Review Request 2289: Fixed 'cannot import name CryptoError' on Fedora 23.
Radek Novacek
reviewboard at gallagherhome.com
Thu Mar 19 07:44:44 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/2289/#review3783
-----------------------------------------------------------
src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py (line 433)
<http://reviewboard-openlmi.rhcloud.com/r/2289/#comment2008>
Don't use bare `except:`, it catches all exception like KeyboardInterrupt.
Use at least `except Exception`.
src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py (line 485)
<http://reviewboard-openlmi.rhcloud.com/r/2289/#comment2009>
Same as above.
- Radek Novacek
On March 18, 2015, 10 a.m., Jan Safranek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/2289/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 10 a.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-storage
>
>
> Description
> -------
>
> Fixed "cannot import name CryptoError" on Fedora 23.
>
> Blivet no longer defines this exception.
>
>
> Diffs
> -----
>
> src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py cd8fd1b1f0bd2c8d5e466ee5679800dc39ad324d
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/2289/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Safranek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-reviews/attachments/20150319/a59464c5/attachment.html>
More information about the openlmi-reviews
mailing list