[From nobody Thu Oct 2 14:33:46 2014 From: Radek Novacek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Michal Minar" <miminar@redhat.com>, "scanbot" <jsafrane@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org>, "Radek Novacek" <rnovacek@redhat.com> References: <20140929090344.52584.10113@ex-std-node115.prod.rhcloud.com> In-Reply-To: <20140929090344.52584.10113@ex-std-node115.prod.rhcloud.com> Date: Tue, 30 Sep 2014 07:17:35 -0000 Reply-To: Radek Novacek <rnovacek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140930071735.52584.53142@ex-std-node115.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============2187272360368742679==" Subject: Re: Review Request 2074: networking [2/3] Return proper error message from the methods Message: 22 --===============2187272360368742679== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2074/ ----------------------------------------------------------- (Updated Sept. 30, 2014, 9:17 a.m.) Review request for OpenLMI Developers. Changes ------- Use own macro that will free memory instead of KReturn2/CMReturnWithChars Repository: openlmi-networking Description ------- Return proper error message from the methods The CIM methods used to return just error number without specification of the error message. This patch adds support for error messages. Diffs (updated) ----- src/LMI_BondingMasterSettingDataProvider.c 3c260167c4bc73864f9af598fed6edf7565a4636 src/LMI_BondingSlaveSettingDataProvider.c c0c383d0b08d254a0df2baff81104aa99422d909 src/LMI_BridgingMasterSettingDataProvider.c e30b7a4532c2720e67f60c383f4c509c6ce203fb src/LMI_BridgingSlaveSettingDataProvider.c 898e45423c17cf0255d2204e4cf623a6562a7859 src/LMI_DNSSettingDataProvider.c 68004da955deca3faef4da485af835bfc7d4c591 src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c 2edf6cd411c199fc8092dc49ee3ffcc0299989e6 src/LMI_IPAssignmentSettingDataProvider.c 5cee9d1cfdf6e058168c632c265e4381a73bdb69 src/LMI_IPConfigurationServiceProvider.c b1fc9be16e461d86993cc34360566e09aa7d3d19 src/LMI_IPNetworkConnectionCapabilitiesProvider.c 30d543cb81f4d35aae7db0bacbcff268918524d8 src/LMI_IPRouteSettingDataProvider.c a32b06a9d0d5d54843de5a9eac0965bd161c07e7 src/LMI_NetworkJobProvider.c d2ca4ad3217362b1400092d7f428b8b370ea3398 src/connection.h dd33b820ca1416224fa5057fef592b4e4c97da5d src/connection.c ef9b34e2c9f0562e3a1be3ec863cae6a3bd9beb1 src/connection_nm.c 6c6abd55500cfa14cb50ce0f402f486f43734fd8 src/connection_private.h 2855da38355ff4ca466688af2852b7f3acaa83ab src/globals.h 0f79b7daacaf77d8c6eb8e62cfc3cb6d105ccd24 src/ipassignmentsettingdata.h 14d83155967b5009ebbf9be744ed20cc66b47b52 src/ipassignmentsettingdata.c df0920464f2875c067e5ab4e7838e66d23ca6f46 src/network.h 648d9e50b2bbe7d80892542e70651e9cf1aa215e src/network.c 4f53e516b0bc68ecc6c6766c1f4bf9cb450e3745 src/network_nm.c 9775fbf2b6f03f3f4fcb0d50c3c9e126934cee60 src/network_private.h 65630bcb9e793f30d0a36c780a3d711d662f1d35 src/unittest/mock_nm.c f468ddf51cb5644e60d8f0b281f72ce58f68f023 src/unittest/test_network.c eca35053000e317804921065a36e1550e9e15589 Diff: http://reviewboard-openlmi.rhcloud.com/r/2074/diff/ Testing ------- Thanks, Radek Novacek --===============2187272360368742679== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/2074/">http://reviewboard-openlmi.rhcloud.com/r/2074/</a> </td> </tr> </table> <br /> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Radek Novacek.</div> <p style="color: grey;"><i>Updated Sept. 30, 2014, 9:17 a.m.</i></p> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use own macro that will free memory instead of KReturn2/CMReturnWithChars</pre> </td> </tr> </table> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-networking </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Return proper error message from the methods</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The CIM methods used to return just error number without specification<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> of the error message. This patch adds support for error messages.</p></pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/LMI_BondingMasterSettingDataProvider.c <span style="color: grey">(3c260167c4bc73864f9af598fed6edf7565a4636)</span></li> <li>src/LMI_BondingSlaveSettingDataProvider.c <span style="color: grey">(c0c383d0b08d254a0df2baff81104aa99422d909)</span></li> <li>src/LMI_BridgingMasterSettingDataProvider.c <span style="color: grey">(e30b7a4532c2720e67f60c383f4c509c6ce203fb)</span></li> <li>src/LMI_BridgingSlaveSettingDataProvider.c <span style="color: grey">(898e45423c17cf0255d2204e4cf623a6562a7859)</span></li> <li>src/LMI_DNSSettingDataProvider.c <span style="color: grey">(68004da955deca3faef4da485af835bfc7d4c591)</span></li> <li>src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c <span style="color: grey">(2edf6cd411c199fc8092dc49ee3ffcc0299989e6)</span></li> <li>src/LMI_IPAssignmentSettingDataProvider.c <span style="color: grey">(5cee9d1cfdf6e058168c632c265e4381a73bdb69)</span></li> <li>src/LMI_IPConfigurationServiceProvider.c <span style="color: grey">(b1fc9be16e461d86993cc34360566e09aa7d3d19)</span></li> <li>src/LMI_IPNetworkConnectionCapabilitiesProvider.c <span style="color: grey">(30d543cb81f4d35aae7db0bacbcff268918524d8)</span></li> <li>src/LMI_IPRouteSettingDataProvider.c <span style="color: grey">(a32b06a9d0d5d54843de5a9eac0965bd161c07e7)</span></li> <li>src/LMI_NetworkJobProvider.c <span style="color: grey">(d2ca4ad3217362b1400092d7f428b8b370ea3398)</span></li> <li>src/connection.h <span style="color: grey">(dd33b820ca1416224fa5057fef592b4e4c97da5d)</span></li> <li>src/connection.c <span style="color: grey">(ef9b34e2c9f0562e3a1be3ec863cae6a3bd9beb1)</span></li> <li>src/connection_nm.c <span style="color: grey">(6c6abd55500cfa14cb50ce0f402f486f43734fd8)</span></li> <li>src/connection_private.h <span style="color: grey">(2855da38355ff4ca466688af2852b7f3acaa83ab)</span></li> <li>src/globals.h <span style="color: grey">(0f79b7daacaf77d8c6eb8e62cfc3cb6d105ccd24)</span></li> <li>src/ipassignmentsettingdata.h <span style="color: grey">(14d83155967b5009ebbf9be744ed20cc66b47b52)</span></li> <li>src/ipassignmentsettingdata.c <span style="color: grey">(df0920464f2875c067e5ab4e7838e66d23ca6f46)</span></li> <li>src/network.h <span style="color: grey">(648d9e50b2bbe7d80892542e70651e9cf1aa215e)</span></li> <li>src/network.c <span style="color: grey">(4f53e516b0bc68ecc6c6766c1f4bf9cb450e3745)</span></li> <li>src/network_nm.c <span style="color: grey">(9775fbf2b6f03f3f4fcb0d50c3c9e126934cee60)</span></li> <li>src/network_private.h <span style="color: grey">(65630bcb9e793f30d0a36c780a3d711d662f1d35)</span></li> <li>src/unittest/mock_nm.c <span style="color: grey">(f468ddf51cb5644e60d8f0b281f72ce58f68f023)</span></li> <li>src/unittest/test_network.c <span style="color: grey">(eca35053000e317804921065a36e1550e9e15589)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/2074/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============2187272360368742679==-- ]