[From nobody Tue Sep 23 12:00:25 2014 From: Jan Safranek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Jan Synacek" <jsynacek@redhat.com>, "scanbot" <jsafrane@redhat.com>, "Jan Safranek" <jsafrane@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org> References: <20140922135429.440758.87841@ex-std-node115.prod.rhcloud.com> In-Reply-To: <20140922135429.440758.87841@ex-std-node115.prod.rhcloud.com> Date: Tue, 23 Sep 2014 07:00:45 -0000 Reply-To: Jan Safranek <jsafrane@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140923070045.440758.70393@ex-std-node115.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============2197558553797369980==" Subject: Re: Review Request 2037: selinux: Fixed referencing uninitialized variables. Message: 35 --===============2197558553797369980== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2037/ ----------------------------------------------------------- (Updated Zář. 23, 2014, 9 dop.) Status ------ This change has been marked as submitted. Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- selinux: Fixed referencing uninitialized variables. When semanage_connect() fails, variables 'type', 'range_low', 'range_high' and 'name' were not initialized and were read in 'err:' processing. As a fix, fill in the variables first and then call semanage_connect(). Diffs ----- src/selinux/selinux.c aeb6c82c1d8990aec7c3019a3454abad7b319c11 Diff: http://reviewboard-openlmi.rhcloud.com/r/2037/diff/ Testing ------- Thanks, Jan Safranek --===============2197558553797369980== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/2037/">http://reviewboard-openlmi.rhcloud.com/r/2037/</a> </td> </tr> </table> <br /> <table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1> </td> </tr> </table> <br /> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Jan Safranek.</div> <p style="color: grey;"><i>Updated Zář. 23, 2014, 9 dop.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">selinux: Fixed referencing uninitialized variables. When semanage_connect() fails, variables &#39;type&#39;, &#39;range_low&#39;, &#39;range_high&#39; and &#39;name&#39; were not initialized and were read in &#39;err:&#39; processing. As a fix, fill in the variables first and then call semanage_connect(). </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/selinux/selinux.c <span style="color: grey">(aeb6c82c1d8990aec7c3019a3454abad7b319c11)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/2037/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============2197558553797369980==-- ]