[From nobody Tue Sep 23 12:00:25 2014 From: scanbot <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "scanbot" <jsafrane@redhat.com>, "Jan Safranek" <jsafrane@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org> References: <20140922135430.440756.55603@ex-std-node115.prod.rhcloud.com> In-Reply-To: <20140922135430.440756.55603@ex-std-node115.prod.rhcloud.com> Date: Mon, 22 Sep 2014 14:30:52 -0000 Reply-To: scanbot <jsafrane@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140922143052.440758.43969@ex-std-node115.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============6865843305826195473==" Subject: Re: Review Request 2038: selinux: Print parse_port_range() return values only when the parsing succeeds. Message: 15 --===============6865843305826195473== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2038/#review3390 ----------------------------------------------------------- Autoscan finished OK Scanned reviews: 2038 - scanbot On Sept. 22, 2014, 1:54 p.m., Jan Safranek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/2038/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2014, 1:54 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > selinux: Print parse_port_range() return values only when the parsing succeeds. > > When the function fails, it should not print *low nor *high, as they may not > be initialized. > > > Diffs > ----- > > src/selinux/LMI_SELinuxServiceProvider.c 791d539659dc789e1292517a5dba6175b8d8ce00 > > Diff: http://reviewboard-openlmi.rhcloud.com/r/2038/diff/ > > > Testing > ------- > > > Thanks, > > Jan Safranek > > --===============6865843305826195473== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/2038/">http://reviewboard-openlmi.rhcloud.com/r/2038/</a> </td> </tr> </table> <br /> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Autoscan finished OK Scanned reviews: 2038</pre> <br /> <p>- scanbot</p> <br /> <p>On September 22nd, 2014, 1:54 p.m. UTC, Jan Safranek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Jan Safranek.</div> <p style="color: grey;"><i>Updated Sept. 22, 2014, 1:54 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">selinux: Print parse_port_range() return values only when the parsing succeeds. When the function fails, it should not print *low nor *high, as they may not be initialized. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/selinux/LMI_SELinuxServiceProvider.c <span style="color: grey">(791d539659dc789e1292517a5dba6175b8d8ce00)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/2038/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============6865843305826195473==-- ]