[From nobody Wed Sep 10 12:00:15 2014 From: Radek Novacek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Jan Safranek" <jsafrane@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org>, "Radek Novacek" <rnovacek@redhat.com> References: <20140910100620.248075.25313@ex-std-node115.prod.rhcloud.com> In-Reply-To: <20140910100620.248075.25313@ex-std-node115.prod.rhcloud.com> Date: Wed, 10 Sep 2014 10:09:37 -0000 Reply-To: Radek Novacek <rnovacek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140910100937.248074.64028@ex-std-node115.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============6221971037755866908==" Subject: Re: Review Request 2018: providers [1/1] cmake: add doc-prep target that prepare the documenation rst files Message: 40 --===============6221971037755866908== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 10, 2014, 12:06 p.m., Jan Safranek wrote: > > doc/admin/CMakeLists.txt, line 90 > > <http://reviewboard-openlmi.rhcloud.com/r/2018/diff/1/?file=11845#file11845line90> > > > > "do not create html?" good catch :) - Radek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2018/#review3359 ----------------------------------------------------------- On Sept. 10, 2014, 10:50 a.m., Radek Novacek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/2018/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2014, 10:50 a.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > cmake: add doc-prep target that prepare the documenation rst files > > This is needed for joint documentation of all providers. > > > Diffs > ----- > > doc/admin/CMakeLists.txt ba25cdc1eb80ccd432982447b30b13f731287b74 > > Diff: http://reviewboard-openlmi.rhcloud.com/r/2018/diff/ > > > Testing > ------- > > > Thanks, > > Radek Novacek > > --===============6221971037755866908== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/2018/">http://reviewboard-openlmi.rhcloud.com/r/2018/</a> </td> </tr> </table> <br /> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <p style="margin-top: 0;">On September 10th, 2014, 12:06 p.m. CEST, <b>Jan Safranek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;"> <thead> <tr> <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;"> <a href="http://reviewboard-openlmi.rhcloud.com/r/2018/diff/1/?file=11845#file11845line90" style="color: black; font-weight: bold; text-decoration: underline;">doc/admin/CMakeLists.txt</a> <span style="font-weight: normal;"> (Diff revision 1) </span> </th> </tr> </thead> <tbody> <tr> <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">90</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># PROVIDER-doc-prep - prepare all the .rst but do not create .rst</span></pre></td> </tr> </tbody> </table> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"do not create html?"</p></pre> </blockquote> </blockquote> <pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">good catch :)</p></pre> <br /> <p>- Radek</p> <br /> <p>On September 10th, 2014, 10:50 a.m. CEST, Radek Novacek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Radek Novacek.</div> <p style="color: grey;"><i>Updated Sept. 10, 2014, 10:50 a.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">cmake: add doc-prep target that prepare the documenation rst files This is needed for joint documentation of all providers. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>doc/admin/CMakeLists.txt <span style="color: grey">(ba25cdc1eb80ccd432982447b30b13f731287b74)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/2018/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============6221971037755866908==-- ]