[From nobody Sat Sep 6 12:00:17 2014 From: Jan Safranek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Radek Novacek" <rnovacek@redhat.com>, "Jan Safranek" <jsafrane@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org> References: <20140905085522.248075.19699@ex-std-node115.prod.rhcloud.com> In-Reply-To: <20140905085522.248075.19699@ex-std-node115.prod.rhcloud.com> Date: Fri, 05 Sep 2014 12:34:21 -0000 Reply-To: Jan Safranek <jsafrane@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140905123421.248074.11263@ex-std-node115.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============8708052331070296783==" Subject: Re: Review Request 2009: storage: Use the same DeviceID for inactive LVs as for the active. Message: 1 --===============8708052331070296783== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2009/ ----------------------------------------------------------- (Updated Zář. 5, 2014, 2:34 odp.) Status ------ This change has been marked as submitted. Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Use the same DeviceID for inactive LVs as for the active. When an LV becomes inactive, it should keep the same DeviceID. Inacive LVs don't carry too much information, blivek knows only /dev/mapper/<vg>-<lv> path, so we must use this ID also for the active ones. Diffs ----- src/lmi/storage/util/storage.py 0a532e902eb5c8e8c958be5939d7c94b0220671b Diff: http://reviewboard-openlmi.rhcloud.com/r/2009/diff/ Testing ------- Thanks, Jan Safranek --===============8708052331070296783== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/2009/">http://reviewboard-openlmi.rhcloud.com/r/2009/</a> </td> </tr> </table> <br /> <table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1> </td> </tr> </table> <br /> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Jan Safranek.</div> <p style="color: grey;"><i>Updated Zář. 5, 2014, 2:34 odp.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-storage </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use the same DeviceID for inactive LVs as for the active. When an LV becomes inactive, it should keep the same DeviceID. Inacive LVs don&#39;t carry too much information, blivek knows only /dev/mapper/&lt;vg&gt;-&lt;lv&gt; path, so we must use this ID also for the active ones. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/lmi/storage/util/storage.py <span style="color: grey">(0a532e902eb5c8e8c958be5939d7c94b0220671b)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/2009/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============8708052331070296783==-- ]