[From nobody Fri Sep 5 12:00:16 2014 From: Jan Safranek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Peter Schiffer" <pschiffe@redhat.com>, "Jan Safranek" <jsafrane@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org> References: <20140904174859.248075.21377@ex-std-node115.prod.rhcloud.com> In-Reply-To: <20140904174859.248075.21377@ex-std-node115.prod.rhcloud.com> Date: Fri, 05 Sep 2014 11:29:37 -0000 Reply-To: Jan Safranek <jsafrane@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140905112937.248075.69705@ex-std-node115.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============2567845566686143118==" Subject: Re: Review Request 2007: hardware: added IPMI IP info to the LMI_Chassis Message: 40 --===============2567845566686143118== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2007/#review3326 ----------------------------------------------------------- NACK from my side. IPMI address is not that simple to be as one string property - there may be multiple addresses of IPMI interface and it can even have ipv6 address. There is ongoing effort to provide complex IPMI management in https://github.com/praveen-pk/lmi-bmc, we should package this when it's ready and do not invent something new. - Jan Safranek On Zář. 4, 2014, 7:48 odp., Peter Schiffer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/2007/ > ----------------------------------------------------------- > > (Updated Zář. 4, 2014, 7:48 odp.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > hardware: added IPMI IP info to the LMI_Chassis > > > Diffs > ----- > > mof/60_LMI_Hardware.mof 977ddad90cd1e355166dc68b63b07b73ec858797 > src/hardware/CMakeLists.txt 92a9ea6fc1a1c3fde8c2a5465c54a5f1abffa17c > src/hardware/LMI_ChassisProvider.c 66d793a08a77804c466fd4622d490d5a2c715a7e > src/hardware/ipmi.h PRE-CREATION > src/hardware/ipmi.c PRE-CREATION > > Diff: http://reviewboard-openlmi.rhcloud.com/r/2007/diff/ > > > Testing > ------- > > > Thanks, > > Peter Schiffer > > --===============2567845566686143118== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/2007/">http://reviewboard-openlmi.rhcloud.com/r/2007/</a> </td> </tr> </table> <br /> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">NACK from my side. IPMI address is not that simple to be as one string property - there may be multiple addresses of IPMI interface and it can even have ipv6 address.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is ongoing effort to provide complex IPMI management in https://github.com/praveen-pk/lmi-bmc, we should package this when it's ready and do not invent something new.</p></pre> <br /> <p>- Jan Safranek</p> <br /> <p>On září 4th, 2014, 7:48 odp. CEST, Peter Schiffer wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Peter Schiffer.</div> <p style="color: grey;"><i>Updated Zář. 4, 2014, 7:48 odp.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hardware: added IPMI IP info to the LMI_Chassis</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>mof/60_LMI_Hardware.mof <span style="color: grey">(977ddad90cd1e355166dc68b63b07b73ec858797)</span></li> <li>src/hardware/CMakeLists.txt <span style="color: grey">(92a9ea6fc1a1c3fde8c2a5465c54a5f1abffa17c)</span></li> <li>src/hardware/LMI_ChassisProvider.c <span style="color: grey">(66d793a08a77804c466fd4622d490d5a2c715a7e)</span></li> <li>src/hardware/ipmi.h <span style="color: grey">(PRE-CREATION)</span></li> <li>src/hardware/ipmi.c <span style="color: grey">(PRE-CREATION)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/2007/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============2567845566686143118==-- ]