[From nobody Fri Sep 5 12:00:16 2014 From: Radek Novacek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org>, "Jan Safranek" <jsafrane@redhat.com>, "Radek Novacek" <rnovacek@redhat.com> References: <20140905085522.248075.19699@ex-std-node115.prod.rhcloud.com> In-Reply-To: <20140905085522.248075.19699@ex-std-node115.prod.rhcloud.com> Date: Fri, 05 Sep 2014 09:00:07 -0000 Reply-To: Radek Novacek <rnovacek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140905090007.248074.93543@ex-std-node115.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============3084751451785525121==" Subject: Re: Review Request 2009: storage: Use the same DeviceID for inactive LVs as for the active. Message: 37 --===============3084751451785525121== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2009/#review3324 ----------------------------------------------------------- Ship it! Ship It! - Radek Novacek On Sept. 5, 2014, 10:55 a.m., Jan Safranek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/2009/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2014, 10:55 a.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-storage > > > Description > ------- > > Use the same DeviceID for inactive LVs as for the active. > > When an LV becomes inactive, it should keep the same DeviceID. Inacive LVs > don't carry too much information, blivek knows only /dev/mapper/<vg>-<lv> path, > so we must use this ID also for the active ones. > > > Diffs > ----- > > src/lmi/storage/util/storage.py 0a532e902eb5c8e8c958be5939d7c94b0220671b > > Diff: http://reviewboard-openlmi.rhcloud.com/r/2009/diff/ > > > Testing > ------- > > > Thanks, > > Jan Safranek > > --===============3084751451785525121== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/2009/">http://reviewboard-openlmi.rhcloud.com/r/2009/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre> <br /> <p>- Radek Novacek</p> <br /> <p>On September 5th, 2014, 10:55 a.m. CEST, Jan Safranek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Jan Safranek.</div> <p style="color: grey;"><i>Updated Sept. 5, 2014, 10:55 a.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-storage </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use the same DeviceID for inactive LVs as for the active. When an LV becomes inactive, it should keep the same DeviceID. Inacive LVs don&#39;t carry too much information, blivek knows only /dev/mapper/&lt;vg&gt;-&lt;lv&gt; path, so we must use this ID also for the active ones. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/lmi/storage/util/storage.py <span style="color: grey">(0a532e902eb5c8e8c958be5939d7c94b0220671b)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/2009/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============3084751451785525121==-- ]