[From nobody Wed Aug 20 12:00:19 2014 From: Michal Minar <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: Michal Minar <miminar@redhat.com>, =?utf-8?b?VG9tw6HFoSBCxb5hdGVr?= <tbzatek@redhat.com>, OpenLMI Developers <openlmi-reviews@lists.fedorahosted.org> References: <20140819163249.154623.42785@ex-std-node115.prod.rhcloud.com> In-Reply-To: <20140819163249.154623.42785@ex-std-node115.prod.rhcloud.com> Date: Wed, 20 Aug 2014 11:27:34 -0000 Reply-To: Michal Minar <miminar@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140820112734.154622.66085@ex-std-node115.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============6993603110795020938==" Subject: Re: Review Request 1965: devassistant: Adjust assistants to the new 0.9.0 DA API Message: 24 --===============6993603110795020938== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1965/#review3233 ----------------------------------------------------------- Ship it! Haven't tried it and missing any devassistant experience. - Michal Minar On Srp. 19, 2014, 4:32 odp., Tomáš Bžatek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1965/ > ----------------------------------------------------------- > > (Updated Srp. 19, 2014, 4:32 odp.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > devassistant: Adjust assistants to the new 0.9.0 DA API > > > Diffs > ----- > > tools/devassistant/assistants/crt/c/openlmi.yaml d9d81a51e84856f29d1520ec28a4198c33c2ae87 > tools/devassistant/assistants/crt/python/openlmi-scripts.yaml 9594474a77bcdb996b29c5811f2f1902fec1d80d > tools/devassistant/assistants/crt/python/openlmi.yaml 1a736aa53d8c2c0916f16ed1e28b2fffc8e64ec1 > tools/devassistant/assistants/prep/openlmi-scripts.yaml 5a25eca4000ff1c56410759065f06aac20f69a39 > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1965/diff/ > > > Testing > ------- > > > Thanks, > > Tomáš Bžatek > > --===============6993603110795020938== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1965/">http://reviewboard-openlmi.rhcloud.com/r/1965/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Haven't tried it and missing any devassistant experience.</p></pre> <br /> <p>- Michal Minar</p> <br /> <p>On srpen 19th, 2014, 4:32 odp. UTC, Tomáš Bžatek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Tomáš Bžatek.</div> <p style="color: grey;"><i>Updated Srp. 19, 2014, 4:32 odp.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">devassistant: Adjust assistants to the new 0.9.0 DA API</p></pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>tools/devassistant/assistants/crt/c/openlmi.yaml <span style="color: grey">(d9d81a51e84856f29d1520ec28a4198c33c2ae87)</span></li> <li>tools/devassistant/assistants/crt/python/openlmi-scripts.yaml <span style="color: grey">(9594474a77bcdb996b29c5811f2f1902fec1d80d)</span></li> <li>tools/devassistant/assistants/crt/python/openlmi.yaml <span style="color: grey">(1a736aa53d8c2c0916f16ed1e28b2fffc8e64ec1)</span></li> <li>tools/devassistant/assistants/prep/openlmi-scripts.yaml <span style="color: grey">(5a25eca4000ff1c56410759065f06aac20f69a39)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1965/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============6993603110795020938==-- ]