[From nobody Wed Jun 25 12:00:16 2014 From: Jan Safranek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Michal Minar" <miminar@redhat.com>, "Jan Safranek" <jsafrane@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org> References: <20140624131040.22864.86121@ex-std-node115.prod.rhcloud.com> In-Reply-To: <20140624131040.22864.86121@ex-std-node115.prod.rhcloud.com> Date: Tue, 24 Jun 2014 14:11:53 -0000 Reply-To: Jan Safranek <jsafrane@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140624141153.22864.65202@ex-std-node115.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============1414922868419654783==" Subject: Re: Review Request 1831: openlmi-software: Fix BTRFS: [3/4] Use real devices only where appropriate. Message: 20 --===============1414922868419654783== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1831/ ----------------------------------------------------------- (Updated Čer. 24, 2014, 4:11 odp.) Status ------ This change has been marked as submitted. Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Use real devices only where appropriate. This partly reverts patch bc82c6e4a69b7005a2fd12ba645fd7ac6b335d13. We need to use BTRFSVolumeDevice for filesystem and mount management - we want to have only one instance of LMI_LocalFileSystem for a btrfs over multiple devices and only one LMI_MountedFilesystem. However, for all *device* manipulation, we need to use the real devices. Diffs ----- src/lmi/storage/LMI_FileSystemConfigurationService.py 6c62e9b9cced75c39ac9573708dc0e30cce7372e src/lmi/storage/LMI_HostedMount.py 5898dbdc3f34674302a8354eb73d785bd4fd5e28 src/lmi/storage/LMI_MountPoint.py 8b7ab23b9f2d0a7d577de1a1737b028626f9edf3 src/lmi/storage/LMI_MountedFileSystem.py d480dc9a1b7aa74a009369069251d5ec17e9ceaa src/lmi/storage/LMI_TransientFileSystem.py c93da183dfdfcb80b4ecc00d136b81322d1485af src/lmi/storage/LocalFileSystemProvider.py 9eacfed414d450bda3f5bbca5aa6dd6fbd898a0d Diff: http://reviewboard-openlmi.rhcloud.com/r/1831/diff/ Testing ------- Thanks, Jan Safranek --===============1414922868419654783== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1831/">http://reviewboard-openlmi.rhcloud.com/r/1831/</a> </td> </tr> </table> <br /> <table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1> </td> </tr> </table> <br /> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Jan Safranek.</div> <p style="color: grey;"><i>Updated Čer. 24, 2014, 4:11 odp.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-storage </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use real devices only where appropriate. This partly reverts patch bc82c6e4a69b7005a2fd12ba645fd7ac6b335d13. We need to use BTRFSVolumeDevice for filesystem and mount management - we want to have only one instance of LMI_LocalFileSystem for a btrfs over multiple devices and only one LMI_MountedFilesystem. However, for all *device* manipulation, we need to use the real devices. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/lmi/storage/LMI_FileSystemConfigurationService.py <span style="color: grey">(6c62e9b9cced75c39ac9573708dc0e30cce7372e)</span></li> <li>src/lmi/storage/LMI_HostedMount.py <span style="color: grey">(5898dbdc3f34674302a8354eb73d785bd4fd5e28)</span></li> <li>src/lmi/storage/LMI_MountPoint.py <span style="color: grey">(8b7ab23b9f2d0a7d577de1a1737b028626f9edf3)</span></li> <li>src/lmi/storage/LMI_MountedFileSystem.py <span style="color: grey">(d480dc9a1b7aa74a009369069251d5ec17e9ceaa)</span></li> <li>src/lmi/storage/LMI_TransientFileSystem.py <span style="color: grey">(c93da183dfdfcb80b4ecc00d136b81322d1485af)</span></li> <li>src/lmi/storage/LocalFileSystemProvider.py <span style="color: grey">(9eacfed414d450bda3f5bbca5aa6dd6fbd898a0d)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1831/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============1414922868419654783==-- ]