[From nobody Tue Jun 24 10:58:55 2014 From: scanbot <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Michal Minar" <miminar@redhat.com>, "scanbot" <jsafrane@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org> References: <20140623140630.22865.85024@ex-std-node115.prod.rhcloud.com> In-Reply-To: <20140623140630.22865.85024@ex-std-node115.prod.rhcloud.com> Date: Mon, 23 Jun 2014 14:11:02 -0000 Reply-To: scanbot <jsafrane@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140623141102.22864.762@ex-std-node115.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============8857278126329850305==" Subject: Re: Review Request 1812: providers [2/2] all: fetch computer system using safe functions Message: 20 --===============8857278126329850305== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1812/#review2817 ----------------------------------------------------------- Autoscan started for review(s) 1811[1], 1801[1], 1812[1] - scanbot On June 23, 2014, 2:06 p.m., Michal Minar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1812/ > ----------------------------------------------------------- > > (Updated June 23, 2014, 2:06 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > all: fetch computer system using safe functions > > Use newly added utility functions to fetch computer system or its system > name with current context either from cache or from broker. > > > Diffs > ----- > > src/account/LMI_AccountCapabilitiesProvider.c 9ea80c07e21668044e67a5b782340d3b2c36d028 > src/account/LMI_AccountManagementServiceCapabilitiesProvider.c b41949a8495dca4d70db21420d400c70b3b88184 > src/account/LMI_AccountManagementServiceProvider.c 652cd3a9799345b8008430f11be0914341d31769 > src/account/LMI_AccountOnSystemProvider.c 879d9691cbad3be65d36d74b9ee62dd589124532 > src/account/LMI_AccountProvider.c 9e09959cd5809d85fc01dffd57bf7ec872ba81e7 > src/account/LMI_AssignedAccountIdentityProvider.c 4d94c9b3f62c66185432d2858a012d1a77db3e5e > src/account/LMI_HostedAccountManagementServiceProvider.c ffe9b8e142860c58322f9b71de1503a1b87fa57d > src/account/LMI_OwningGroupProvider.c 0974aef74bef45d23f181edc650b9f4953ec90b7 > src/account/LMI_ServiceAffectsIdentityProvider.c 2cee1f7e0d6e7783404f2f107041a6a3cfb0ac19 > src/fan/LMI_FanAssociatedSensorProvider.c 5b6f7766a99b031199d3882c3aea5598b981d24b > src/fan/LMI_FanProvider.c e2f0b0e2c7e87fc7f2ae98030645ddbec6a89a60 > src/fan/LMI_FanSensorProvider.c beac931a78f5d5036901c296a44dba487851ac82 > src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c dbd022e472ed10f20b925ae53d3ce9a36fd3d5b0 > src/hardware/LMI_BatteryProvider.c 2037e865ff782d416f7423e98fcafa2c6db605d9 > src/hardware/LMI_BatterySystemDeviceProvider.c 4c3b705897ff4a3f433e54cdfb597049ff450ed8 > src/hardware/LMI_ChassisComputerSystemPackageProvider.c ca83c57599f0e723f729d073b7a622ec30f81ee1 > src/hardware/LMI_DiskDriveATAPortProvider.c b4de4a07567fbd4fc44dd70aaccdd1595ab6ecab > src/hardware/LMI_DiskDriveATAProtocolEndpointProvider.c 56d71e61e00f7372e360ddd4bfbc4284e9fe3b2e > src/hardware/LMI_DiskDriveDeviceSAPImplementationProvider.c 120132173cce2fc6b875d0d0bef0c06e774a2da6 > src/hardware/LMI_DiskDriveElementSoftwareIdentityProvider.c aff9540aae7c40f37f7e22352883958fe43d15e2 > src/hardware/LMI_DiskDriveProvider.c c71d075edabfe20bb67d3b2480dce3a575161ef0 > src/hardware/LMI_DiskDriveRealizesProvider.c af15405da4716bad44fa9f8c80a8e1ea3d825e08 > src/hardware/LMI_DiskDriveSAPAvailableForElementProvider.c c7b130ba8981ba52cdf4153e203fc80f15cb13e8 > src/hardware/LMI_DiskDriveSystemDeviceProvider.c 7f8f668dccc4eeeea3d3b3a2121118bcdaf8395b > src/hardware/LMI_MemoryProvider.c 9ec9667188e31d518117558bb7470d77e6446a8a > src/hardware/LMI_MemorySystemDeviceProvider.c b91432b77b351915db3e24967bed3e403227c511 > src/hardware/LMI_PCIBridgeProvider.c d976f8f5f88f1ba723b2e56ccb27f10b3e947ad3 > src/hardware/LMI_PCIBridgeSystemDeviceProvider.c 8beb9ffd56f60e824cdca7797cc49a48bf711fc6 > src/hardware/LMI_PCIDeviceProvider.c d1056282ece5b666e26b0ca3f0ec6137f11a6ba9 > src/hardware/LMI_PCIDeviceSystemDeviceProvider.c 99a8ca22c630e8f0010c49b21de4a075df2b55ad > src/hardware/LMI_PhysicalBatteryRealizesProvider.c 114e613234942c507bca011523772a136de6e19f > src/hardware/LMI_PhysicalMemoryRealizesProvider.c 77f4d85ca974840506baa1294cef33ccf55e64b1 > src/hardware/LMI_PointingDeviceProvider.c e7edec32b6f9be2b36409d1db9b611570e74d703 > src/hardware/LMI_ProcessorCacheMemoryProvider.c bbb8989031d8aafb2d2e005e91b2c9a19ed58106 > src/hardware/LMI_ProcessorChipRealizesProvider.c 0f404918094d58f61695fefed60c31146fc497cb > src/hardware/LMI_ProcessorElementCapabilitiesProvider.c 61a9fe8796c2bb6733c65a580230a0ba570b4afc > src/hardware/LMI_ProcessorProvider.c c3134c4e4f1d5b6993f984a94be18c9c8c42ed2a > src/hardware/LMI_ProcessorSystemDeviceProvider.c 761adf0806fa661a4b67254299c31ac38edd316a > src/libs/indsender/ind_sender.c 7a2f9459fc0286d50aa881ed3443a1d51cde8cdc > src/locale/LMI_LocaleProvider.c 875916145df568460b976c4faf2890139608495d > src/logicalfile/LMI_DirectoryContainsFileProvider.c 8511bfa004060288f3b0bc8a390f105c44a8b0e1 > src/logicalfile/LMI_FileIdentityProvider.c 781189513d50fefc8051b975c0216a0a053d4d0b > src/logicalfile/LMI_RootDirectoryProvider.c 501638f37f41a3f635b7af4f80d86175143bbe5a > src/logicalfile/file.h 518cc7764ba49b9b037290c815c48470a55121a0 > src/power/LMI_AssociatedPowerManagementServiceProvider.c 04bd5fb6156884fda99d30e7ce491691bd19b9e7 > src/power/LMI_ElementCapabilitiesProvider.c f8875e1eb9fc74a0b4483d3b99c6c60a6c28c882 > src/power/LMI_HostedPowerManagementServiceProvider.c 993d676cc4fa89e755ba975665b79540df3e315a > src/power/LMI_PowerManagementServiceProvider.c a4778abd8967368021eace561b499f6e8e2c9424 > src/realmd/LMI_HostedRealmdServiceProvider.c 08184d2e66fe611ea6fe88cd44867976be5714ca > src/realmd/LMI_RealmdServiceProvider.c 7680580a5b360a2a96f8dc462e659c9996bc6aa0 > src/service-dbus/LMI_ServiceProvider.c c3d59387b9b8cddbf6609f06f8bbe6a555534644 > src/service/LMI_ServiceProvider.c dec539d8b0a9ffd1358bf053a0ed343865c9a55e > src/software-dbus/LMI_HostedSoftwareCollectionProvider.c 7fcd1de085bd6a009da78e729d06643e8cf3fa6a > src/software-dbus/LMI_HostedSoftwareIdentityResourceProvider.c d6f9bb66d93bd2cfe7ad35c74f6d744cff253d7e > src/software-dbus/LMI_InstalledSoftwareIdentityProvider.c 1f61471748b1ce946095d50bca7c245e586c05fb > src/software-dbus/LMI_MemberOfSoftwareCollectionProvider.c b50f420ba2c3da14d03b053d2653dd008a216ea0 > src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c 62864fd327d1a251e6d42225300decd444ea8d5a > src/software-dbus/LMI_SoftwareIdentityProvider.c ffe15be89d0f188d226b6f3c93485cbbd0539b79 > src/software-dbus/LMI_SoftwareIdentityResourceProvider.c 18d3946957d57f1ac0f7a7ce6d68d921a12325eb > src/software-dbus/sw-utils.h f9e34562560545cf5b74e251cc5fa5d9da5137cc > src/software-dbus/sw-utils.c 93966c3b2412598d21699a3e034cb961cdb199c9 > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1812/diff/ > > > Testing > ------- > > > Thanks, > > Michal Minar > > --===============8857278126329850305== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1812/">http://reviewboard-openlmi.rhcloud.com/r/1812/</a> </td> </tr> </table> <br /> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Autoscan started for review(s) 1811[1], 1801[1], 1812[1]</pre> <br /> <p>- scanbot</p> <br /> <p>On June 23rd, 2014, 2:06 p.m. UTC, Michal Minar wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Michal Minar.</div> <p style="color: grey;"><i>Updated June 23, 2014, 2:06 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">all: fetch computer system using safe functions Use newly added utility functions to fetch computer system or its system name with current context either from cache or from broker. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/account/LMI_AccountCapabilitiesProvider.c <span style="color: grey">(9ea80c07e21668044e67a5b782340d3b2c36d028)</span></li> <li>src/account/LMI_AccountManagementServiceCapabilitiesProvider.c <span style="color: grey">(b41949a8495dca4d70db21420d400c70b3b88184)</span></li> <li>src/account/LMI_AccountManagementServiceProvider.c <span style="color: grey">(652cd3a9799345b8008430f11be0914341d31769)</span></li> <li>src/account/LMI_AccountOnSystemProvider.c <span style="color: grey">(879d9691cbad3be65d36d74b9ee62dd589124532)</span></li> <li>src/account/LMI_AccountProvider.c <span style="color: grey">(9e09959cd5809d85fc01dffd57bf7ec872ba81e7)</span></li> <li>src/account/LMI_AssignedAccountIdentityProvider.c <span style="color: grey">(4d94c9b3f62c66185432d2858a012d1a77db3e5e)</span></li> <li>src/account/LMI_HostedAccountManagementServiceProvider.c <span style="color: grey">(ffe9b8e142860c58322f9b71de1503a1b87fa57d)</span></li> <li>src/account/LMI_OwningGroupProvider.c <span style="color: grey">(0974aef74bef45d23f181edc650b9f4953ec90b7)</span></li> <li>src/account/LMI_ServiceAffectsIdentityProvider.c <span style="color: grey">(2cee1f7e0d6e7783404f2f107041a6a3cfb0ac19)</span></li> <li>src/fan/LMI_FanAssociatedSensorProvider.c <span style="color: grey">(5b6f7766a99b031199d3882c3aea5598b981d24b)</span></li> <li>src/fan/LMI_FanProvider.c <span style="color: grey">(e2f0b0e2c7e87fc7f2ae98030645ddbec6a89a60)</span></li> <li>src/fan/LMI_FanSensorProvider.c <span style="color: grey">(beac931a78f5d5036901c296a44dba487851ac82)</span></li> <li>src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c <span style="color: grey">(dbd022e472ed10f20b925ae53d3ce9a36fd3d5b0)</span></li> <li>src/hardware/LMI_BatteryProvider.c <span style="color: grey">(2037e865ff782d416f7423e98fcafa2c6db605d9)</span></li> <li>src/hardware/LMI_BatterySystemDeviceProvider.c <span style="color: grey">(4c3b705897ff4a3f433e54cdfb597049ff450ed8)</span></li> <li>src/hardware/LMI_ChassisComputerSystemPackageProvider.c <span style="color: grey">(ca83c57599f0e723f729d073b7a622ec30f81ee1)</span></li> <li>src/hardware/LMI_DiskDriveATAPortProvider.c <span style="color: grey">(b4de4a07567fbd4fc44dd70aaccdd1595ab6ecab)</span></li> <li>src/hardware/LMI_DiskDriveATAProtocolEndpointProvider.c <span style="color: grey">(56d71e61e00f7372e360ddd4bfbc4284e9fe3b2e)</span></li> <li>src/hardware/LMI_DiskDriveDeviceSAPImplementationProvider.c <span style="color: grey">(120132173cce2fc6b875d0d0bef0c06e774a2da6)</span></li> <li>src/hardware/LMI_DiskDriveElementSoftwareIdentityProvider.c <span style="color: grey">(aff9540aae7c40f37f7e22352883958fe43d15e2)</span></li> <li>src/hardware/LMI_DiskDriveProvider.c <span style="color: grey">(c71d075edabfe20bb67d3b2480dce3a575161ef0)</span></li> <li>src/hardware/LMI_DiskDriveRealizesProvider.c <span style="color: grey">(af15405da4716bad44fa9f8c80a8e1ea3d825e08)</span></li> <li>src/hardware/LMI_DiskDriveSAPAvailableForElementProvider.c <span style="color: grey">(c7b130ba8981ba52cdf4153e203fc80f15cb13e8)</span></li> <li>src/hardware/LMI_DiskDriveSystemDeviceProvider.c <span style="color: grey">(7f8f668dccc4eeeea3d3b3a2121118bcdaf8395b)</span></li> <li>src/hardware/LMI_MemoryProvider.c <span style="color: grey">(9ec9667188e31d518117558bb7470d77e6446a8a)</span></li> <li>src/hardware/LMI_MemorySystemDeviceProvider.c <span style="color: grey">(b91432b77b351915db3e24967bed3e403227c511)</span></li> <li>src/hardware/LMI_PCIBridgeProvider.c <span style="color: grey">(d976f8f5f88f1ba723b2e56ccb27f10b3e947ad3)</span></li> <li>src/hardware/LMI_PCIBridgeSystemDeviceProvider.c <span style="color: grey">(8beb9ffd56f60e824cdca7797cc49a48bf711fc6)</span></li> <li>src/hardware/LMI_PCIDeviceProvider.c <span style="color: grey">(d1056282ece5b666e26b0ca3f0ec6137f11a6ba9)</span></li> <li>src/hardware/LMI_PCIDeviceSystemDeviceProvider.c <span style="color: grey">(99a8ca22c630e8f0010c49b21de4a075df2b55ad)</span></li> <li>src/hardware/LMI_PhysicalBatteryRealizesProvider.c <span style="color: grey">(114e613234942c507bca011523772a136de6e19f)</span></li> <li>src/hardware/LMI_PhysicalMemoryRealizesProvider.c <span style="color: grey">(77f4d85ca974840506baa1294cef33ccf55e64b1)</span></li> <li>src/hardware/LMI_PointingDeviceProvider.c <span style="color: grey">(e7edec32b6f9be2b36409d1db9b611570e74d703)</span></li> <li>src/hardware/LMI_ProcessorCacheMemoryProvider.c <span style="color: grey">(bbb8989031d8aafb2d2e005e91b2c9a19ed58106)</span></li> <li>src/hardware/LMI_ProcessorChipRealizesProvider.c <span style="color: grey">(0f404918094d58f61695fefed60c31146fc497cb)</span></li> <li>src/hardware/LMI_ProcessorElementCapabilitiesProvider.c <span style="color: grey">(61a9fe8796c2bb6733c65a580230a0ba570b4afc)</span></li> <li>src/hardware/LMI_ProcessorProvider.c <span style="color: grey">(c3134c4e4f1d5b6993f984a94be18c9c8c42ed2a)</span></li> <li>src/hardware/LMI_ProcessorSystemDeviceProvider.c <span style="color: grey">(761adf0806fa661a4b67254299c31ac38edd316a)</span></li> <li>src/libs/indsender/ind_sender.c <span style="color: grey">(7a2f9459fc0286d50aa881ed3443a1d51cde8cdc)</span></li> <li>src/locale/LMI_LocaleProvider.c <span style="color: grey">(875916145df568460b976c4faf2890139608495d)</span></li> <li>src/logicalfile/LMI_DirectoryContainsFileProvider.c <span style="color: grey">(8511bfa004060288f3b0bc8a390f105c44a8b0e1)</span></li> <li>src/logicalfile/LMI_FileIdentityProvider.c <span style="color: grey">(781189513d50fefc8051b975c0216a0a053d4d0b)</span></li> <li>src/logicalfile/LMI_RootDirectoryProvider.c <span style="color: grey">(501638f37f41a3f635b7af4f80d86175143bbe5a)</span></li> <li>src/logicalfile/file.h <span style="color: grey">(518cc7764ba49b9b037290c815c48470a55121a0)</span></li> <li>src/power/LMI_AssociatedPowerManagementServiceProvider.c <span style="color: grey">(04bd5fb6156884fda99d30e7ce491691bd19b9e7)</span></li> <li>src/power/LMI_ElementCapabilitiesProvider.c <span style="color: grey">(f8875e1eb9fc74a0b4483d3b99c6c60a6c28c882)</span></li> <li>src/power/LMI_HostedPowerManagementServiceProvider.c <span style="color: grey">(993d676cc4fa89e755ba975665b79540df3e315a)</span></li> <li>src/power/LMI_PowerManagementServiceProvider.c <span style="color: grey">(a4778abd8967368021eace561b499f6e8e2c9424)</span></li> <li>src/realmd/LMI_HostedRealmdServiceProvider.c <span style="color: grey">(08184d2e66fe611ea6fe88cd44867976be5714ca)</span></li> <li>src/realmd/LMI_RealmdServiceProvider.c <span style="color: grey">(7680580a5b360a2a96f8dc462e659c9996bc6aa0)</span></li> <li>src/service-dbus/LMI_ServiceProvider.c <span style="color: grey">(c3d59387b9b8cddbf6609f06f8bbe6a555534644)</span></li> <li>src/service/LMI_ServiceProvider.c <span style="color: grey">(dec539d8b0a9ffd1358bf053a0ed343865c9a55e)</span></li> <li>src/software-dbus/LMI_HostedSoftwareCollectionProvider.c <span style="color: grey">(7fcd1de085bd6a009da78e729d06643e8cf3fa6a)</span></li> <li>src/software-dbus/LMI_HostedSoftwareIdentityResourceProvider.c <span style="color: grey">(d6f9bb66d93bd2cfe7ad35c74f6d744cff253d7e)</span></li> <li>src/software-dbus/LMI_InstalledSoftwareIdentityProvider.c <span style="color: grey">(1f61471748b1ce946095d50bca7c245e586c05fb)</span></li> <li>src/software-dbus/LMI_MemberOfSoftwareCollectionProvider.c <span style="color: grey">(b50f420ba2c3da14d03b053d2653dd008a216ea0)</span></li> <li>src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c <span style="color: grey">(62864fd327d1a251e6d42225300decd444ea8d5a)</span></li> <li>src/software-dbus/LMI_SoftwareIdentityProvider.c <span style="color: grey">(ffe15be89d0f188d226b6f3c93485cbbd0539b79)</span></li> <li>src/software-dbus/LMI_SoftwareIdentityResourceProvider.c <span style="color: grey">(18d3946957d57f1ac0f7a7ce6d68d921a12325eb)</span></li> <li>src/software-dbus/sw-utils.h <span style="color: grey">(f9e34562560545cf5b74e251cc5fa5d9da5137cc)</span></li> <li>src/software-dbus/sw-utils.c <span style="color: grey">(93966c3b2412598d21699a3e034cb961cdb199c9)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1812/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============8857278126329850305==-- ]