[From nobody Mon Jun 23 12:00:20 2014 From: Jan Synacek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org>, "Jan Synacek" <jsynacek@redhat.com>, "Jan Safranek" <jsafrane@redhat.com> References: <20140620152519.173366.89146@ex-std-node115.prod.rhcloud.com> In-Reply-To: <20140620152519.173366.89146@ex-std-node115.prod.rhcloud.com> Date: Mon, 23 Jun 2014 10:30:01 -0000 Reply-To: Jan Synacek <jsynacek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140623103001.22865.72074@ex-std-node115.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============7476931873826731759==" Subject: Re: Review Request 1805: openlmi-storage: Use real device instead of dummy blivet's BTRFSVolumeDevice. Message: 47 --===============7476931873826731759== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1805/#review2809 ----------------------------------------------------------- Ship it! Ship It! - Jan Synacek On June 20, 2014, 5:25 p.m., Jan Safranek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1805/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 5:25 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-storage > > > Description > ------- > > Use real device instead of dummy blivet's BTRFSVolumeDevice. > > If there is btrfs filesystem on /dev/sdb1, storage.getDeviceByPath('/dev/sdb1') > returns BTRFVolumeDevice of the btrfs filesystem instead of PartitionDevice. > > What OpenLMI needs is the PartitionDevice. > > For example, 'lmi storage fs create xfs /dev/sdb1' returned 'this device's > formatting cannot be modified' instead of reformatting the device. > > > Diffs > ----- > > src/lmi/storage/LMI_DiskPartition.py 1ef172a9608e8ce6f876b80b678eeeb1b45cd33f > src/lmi/storage/LMI_DiskPartitioningConfigurationService.py 8bdff14290fc8af3e21cbaf6c2e840da562c5b5b > src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py d9ff23696d43d4cb0f0aea4885061eb49b79d030 > src/lmi/storage/LMI_FileSystemConfigurationService.py 5ed5de3af7760b3dbe8725826777890a274868ad > src/lmi/storage/LMI_HostedMount.py fd87ebbc041e990ce7eddb9ad4df276a7fc486b8 > src/lmi/storage/LMI_MountPoint.py 1edc4364fa678135ee431a4ca0b96dc7459e5f71 > src/lmi/storage/LMI_MountedFileSystem.py 1d6ad42eec4863b77153b80391b175fc5ccf471c > src/lmi/storage/LMI_StorageConfigurationService.py 4a96ffefbd2328ccf09950c5ce4b60f2bdc1a0a9 > src/lmi/storage/LMI_TransientFileSystem.py 0629764c8d40ddf9202bf4208a995adb67fa168c > src/lmi/storage/LocalFileSystemProvider.py 93cb949f2ff46276615e101e7f86a322aef675e8 > src/lmi/storage/util/storage.py ff6da1be1eaf2c0098bb465ac711d1e8454dc77a > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1805/diff/ > > > Testing > ------- > > > Thanks, > > Jan Safranek > > --===============7476931873826731759== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1805/">http://reviewboard-openlmi.rhcloud.com/r/1805/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre> <br /> <p>- Jan Synacek</p> <br /> <p>On June 20th, 2014, 5:25 p.m. CEST, Jan Safranek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Jan Safranek.</div> <p style="color: grey;"><i>Updated June 20, 2014, 5:25 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-storage </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use real device instead of dummy blivet&#39;s BTRFSVolumeDevice. If there is btrfs filesystem on /dev/sdb1, storage.getDeviceByPath(&#39;/dev/sdb1&#39;) returns BTRFVolumeDevice of the btrfs filesystem instead of PartitionDevice. What OpenLMI needs is the PartitionDevice. For example, &#39;lmi storage fs create xfs /dev/sdb1&#39; returned &#39;this device&#39;s formatting cannot be modified&#39; instead of reformatting the device. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/lmi/storage/LMI_DiskPartition.py <span style="color: grey">(1ef172a9608e8ce6f876b80b678eeeb1b45cd33f)</span></li> <li>src/lmi/storage/LMI_DiskPartitioningConfigurationService.py <span style="color: grey">(8bdff14290fc8af3e21cbaf6c2e840da562c5b5b)</span></li> <li>src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py <span style="color: grey">(d9ff23696d43d4cb0f0aea4885061eb49b79d030)</span></li> <li>src/lmi/storage/LMI_FileSystemConfigurationService.py <span style="color: grey">(5ed5de3af7760b3dbe8725826777890a274868ad)</span></li> <li>src/lmi/storage/LMI_HostedMount.py <span style="color: grey">(fd87ebbc041e990ce7eddb9ad4df276a7fc486b8)</span></li> <li>src/lmi/storage/LMI_MountPoint.py <span style="color: grey">(1edc4364fa678135ee431a4ca0b96dc7459e5f71)</span></li> <li>src/lmi/storage/LMI_MountedFileSystem.py <span style="color: grey">(1d6ad42eec4863b77153b80391b175fc5ccf471c)</span></li> <li>src/lmi/storage/LMI_StorageConfigurationService.py <span style="color: grey">(4a96ffefbd2328ccf09950c5ce4b60f2bdc1a0a9)</span></li> <li>src/lmi/storage/LMI_TransientFileSystem.py <span style="color: grey">(0629764c8d40ddf9202bf4208a995adb67fa168c)</span></li> <li>src/lmi/storage/LocalFileSystemProvider.py <span style="color: grey">(93cb949f2ff46276615e101e7f86a322aef675e8)</span></li> <li>src/lmi/storage/util/storage.py <span style="color: grey">(ff6da1be1eaf2c0098bb465ac711d1e8454dc77a)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1805/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============7476931873826731759==-- ]