[From nobody Wed May 21 14:37:19 2014 From: "=?utf-8?b?VG9tw6HFoSBCxb5hdGVr?=" <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: =?utf-8?b?VG9tw6HFoSBCxb5hdGVr?= <tbzatek@redhat.com>, Tomas Smetana <tsmetana@redhat.com>, Radek Novacek <rnovacek@redhat.com>, OpenLMI Developers <openlmi-reviews@lists.fedorahosted.org>, Jan Safranek <jsafrane@redhat.com> References: <20140505153226.482126.38670@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20140505153226.482126.38670@ex-std-node147.prod.rhcloud.com> Date: Thu, 15 May 2014 14:21:51 -0000 Reply-To: =?utf-8?b?VG9tw6HFoSBCxb5hdGVr?= <tbzatek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140515142151.457615.11077@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============4962710797655445223==" Subject: Re: Review Request 1647: Include profile (un)registration in the (un)register-PROVIDER make targets Message: 5 --===============4962710797655445223== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1647/ ----------------------------------------------------------- (Updated May 15, 2014, 2:21 p.m.) Status ------ This change has been marked as submitted. Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- This is an attempt to include profile (un)registration within the (un)register-PROVIDER make target. This commit extends the cim_registration macro by an extra argument of the profile file or list of profile files. To preserve API of the CMake modules this extra argument is an variable arg in fact and does not need to be specified. Pass a list variable to specify multiple profile files. Diffs ----- src/service/CMakeLists.txt 6d75d38247a8c06b8f6b5e5f4d3b1f8615c910d9 src/service-dbus/CMakeLists.txt 4ba32316993c78ec6ae41287fc97867e23fcf098 src/realmd/CMakeLists.txt dbf2e5463d9192d6dc1dbf767c7be1242e67eb11 src/power/CMakeLists.txt 44b2109ec5ce0c41c6d7091144bd58c0a86e84a2 src/logicalfile/CMakeLists.txt 3a09a4ad7a545f8a74f73175461943516e3f8fde src/journald/CMakeLists.txt 1e6f19372172e5410f7b902ab5f61cac262fdf69 src/hardware/CMakeLists.txt 29b63d342039a2e19a1fcdfe626cfab2b3a3002f src/fan/CMakeLists.txt 446e38b820ad53ae28b619df538c49f03a33bb69 src/account/CMakeLists.txt 83ca474a00a3a8a514bed4fc787360563ad56d01 cmake/modules/OpenLMIMacros.cmake d55f983d2589bb3bee1a14668275b2ed96142cfa src/software-dbus/CMakeLists.txt 5202c33e302bca4b1a48f71bcdf884ff4e1ba01e tools/devassistant/files/crt/c/openlmi/src/CMakeLists.txt.tpl 237f20e02a0c1dea9de9e74acf462e4b58029438 Diff: http://reviewboard-openlmi.rhcloud.com/r/1647/diff/ Testing ------- Thanks, Tomáš Bžatek --===============4962710797655445223== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1647/">http://reviewboard-openlmi.rhcloud.com/r/1647/</a> </td> </tr> </table> <br /> <table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;"> <tr> <td> <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1> </td> </tr> </table> <br /> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Tomáš Bžatek.</div> <p style="color: grey;"><i>Updated May 15, 2014, 2:21 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> This is an attempt to include profile (un)registration within the (un)register-PROVIDER make target. This commit extends the cim_registration macro by an extra argument of the profile file or list of profile files. To preserve API of the CMake modules this extra argument is an variable arg in fact and does not need to be specified. Pass a list variable to specify multiple profile files. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/service/CMakeLists.txt <span style="color: grey">(6d75d38247a8c06b8f6b5e5f4d3b1f8615c910d9)</span></li> <li>src/service-dbus/CMakeLists.txt <span style="color: grey">(4ba32316993c78ec6ae41287fc97867e23fcf098)</span></li> <li>src/realmd/CMakeLists.txt <span style="color: grey">(dbf2e5463d9192d6dc1dbf767c7be1242e67eb11)</span></li> <li>src/power/CMakeLists.txt <span style="color: grey">(44b2109ec5ce0c41c6d7091144bd58c0a86e84a2)</span></li> <li>src/logicalfile/CMakeLists.txt <span style="color: grey">(3a09a4ad7a545f8a74f73175461943516e3f8fde)</span></li> <li>src/journald/CMakeLists.txt <span style="color: grey">(1e6f19372172e5410f7b902ab5f61cac262fdf69)</span></li> <li>src/hardware/CMakeLists.txt <span style="color: grey">(29b63d342039a2e19a1fcdfe626cfab2b3a3002f)</span></li> <li>src/fan/CMakeLists.txt <span style="color: grey">(446e38b820ad53ae28b619df538c49f03a33bb69)</span></li> <li>src/account/CMakeLists.txt <span style="color: grey">(83ca474a00a3a8a514bed4fc787360563ad56d01)</span></li> <li>cmake/modules/OpenLMIMacros.cmake <span style="color: grey">(d55f983d2589bb3bee1a14668275b2ed96142cfa)</span></li> <li>src/software-dbus/CMakeLists.txt <span style="color: grey">(5202c33e302bca4b1a48f71bcdf884ff4e1ba01e)</span></li> <li>tools/devassistant/files/crt/c/openlmi/src/CMakeLists.txt.tpl <span style="color: grey">(237f20e02a0c1dea9de9e74acf462e4b58029438)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1647/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============4962710797655445223==-- ]