[From nobody Thu May 15 13:22:49 2014 From: scanbot <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: =?utf-8?b?VG9tw6HFoSBCxb5hdGVr?= <tbzatek@redhat.com>, scanbot <jsafrane@redhat.com>, OpenLMI Developers <openlmi-reviews@lists.fedorahosted.org> References: <20140514142259.457615.38345@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20140514142259.457615.38345@ex-std-node147.prod.rhcloud.com> Date: Wed, 14 May 2014 14:41:46 -0000 Reply-To: scanbot <jsafrane@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140514144146.457615.62721@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============0268312559337583301==" Subject: Re: Review Request 1728: account: Don't expose the LMI_Account.UserPassword value Message: 41 --===============0268312559337583301== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1728/#review2621 ----------------------------------------------------------- Autoscan finished OK Scanned reviews: 1728 - scanbot On May 14, 2014, 2:22 p.m., Tomáš Bžatek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1728/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 2:22 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > According to the Simple Identity Management Profile (DSP1034) > document the LMI_Account.UserPassword property should not contain > the password itself, no matter how encrypted it is. It should either > contain an array of zero elements when password has been set or > NULL when password is missing or not configured. > > Another change this commit brings is a more precise behaviour > of LMI_Account.ModifyInstance() method. When the UserPassword > property is array of zero elements, no change regarding password > is made. This case was previously treated as a request for password > removal. The DSP1034 profile doesn't specify such scenario, let's > treat it the same way as the GetInstance() operation. > > > Diffs > ----- > > mof/60_LMI_Account.mof 6bc99c8cbea85b556cfcb073af08e63c089791d9 > src/account/LMI_AccountProvider.c fdb06fffe99198b469def5de91508a766a6a7ecf > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1728/diff/ > > > Testing > ------- > > > Thanks, > > Tomáš Bžatek > > --===============0268312559337583301== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1728/">http://reviewboard-openlmi.rhcloud.com/r/1728/</a> </td> </tr> </table> <br /> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Autoscan finished OK Scanned reviews: 1728</pre> <br /> <p>- scanbot</p> <br /> <p>On May 14th, 2014, 2:22 p.m. UTC, Tomáš Bžatek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Tomáš Bžatek.</div> <p style="color: grey;"><i>Updated May 14, 2014, 2:22 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to the Simple Identity Management Profile (DSP1034) document the LMI_Account.UserPassword property should not contain the password itself, no matter how encrypted it is. It should either contain an array of zero elements when password has been set or NULL when password is missing or not configured. Another change this commit brings is a more precise behaviour of LMI_Account.ModifyInstance() method. When the UserPassword property is array of zero elements, no change regarding password is made. This case was previously treated as a request for password removal. The DSP1034 profile doesn&#39;t specify such scenario, let&#39;s treat it the same way as the GetInstance() operation.</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>mof/60_LMI_Account.mof <span style="color: grey">(6bc99c8cbea85b556cfcb073af08e63c089791d9)</span></li> <li>src/account/LMI_AccountProvider.c <span style="color: grey">(fdb06fffe99198b469def5de91508a766a6a7ecf)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1728/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============0268312559337583301==-- ]