[From nobody Wed Apr 30 13:58:35 2014 From: Jan Safranek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: =?utf-8?b?VG9tw6HFoSBCxb5hdGVr?= <tbzatek@redhat.com>, Jan Safranek <jsafrane@redhat.com>, OpenLMI Developers <openlmi-reviews@lists.fedorahosted.org> References: <20140428111425.482126.41490@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20140428111425.482126.41490@ex-std-node147.prod.rhcloud.com> Date: Tue, 29 Apr 2014 12:22:59 -0000 Reply-To: Jan Safranek <jsafrane@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140429122259.482126.92052@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============5860409415448089677==" Subject: Re: Review Request 1647: Include profile (un)registration in the (un)register-PROVIDER make targets Message: 28 --===============5860409415448089677== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1647/#review2547 ----------------------------------------------------------- Apart from Pegasus problem below, the patch is ok. cmake/modules/OpenLMIMacros.cmake <http://reviewboard-openlmi.rhcloud.com/r/1647/#comment1368> The profile (un-)registration works only in Pegasus, please add '-c tog-pegasus'. - Jan Safranek On April 28, 2014, 1:14 p.m., Tomáš Bžatek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1647/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 1:14 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > This is an attempt to include profile (un)registration within the > (un)register-PROVIDER make target. This commit extends the cim_registration > macro by an extra argument of the profile file. However it is currently > limited to a single argument. > > > Diffs > ----- > > cmake/modules/OpenLMIMacros.cmake d55f983d2589bb3bee1a14668275b2ed96142cfa > src/account/CMakeLists.txt 83ca474a00a3a8a514bed4fc787360563ad56d01 > src/fan/CMakeLists.txt 446e38b820ad53ae28b619df538c49f03a33bb69 > src/hardware/CMakeLists.txt 29b63d342039a2e19a1fcdfe626cfab2b3a3002f > src/journald/CMakeLists.txt 1e6f19372172e5410f7b902ab5f61cac262fdf69 > src/logicalfile/CMakeLists.txt 3a09a4ad7a545f8a74f73175461943516e3f8fde > src/power/CMakeLists.txt 44b2109ec5ce0c41c6d7091144bd58c0a86e84a2 > src/realmd/CMakeLists.txt dbf2e5463d9192d6dc1dbf767c7be1242e67eb11 > src/service-dbus/CMakeLists.txt 4ba32316993c78ec6ae41287fc97867e23fcf098 > src/service/CMakeLists.txt 6d75d38247a8c06b8f6b5e5f4d3b1f8615c910d9 > src/software-dbus/CMakeLists.txt 5202c33e302bca4b1a48f71bcdf884ff4e1ba01e > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1647/diff/ > > > Testing > ------- > > > Thanks, > > Tomáš Bžatek > > --===============5860409415448089677== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1647/">http://reviewboard-openlmi.rhcloud.com/r/1647/</a> </td> </tr> </table> <br /> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apart from Pegasus problem below, the patch is ok.</pre> <br /> <div> <table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;"> <thead> <tr> <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;"> <a href="http://reviewboard-openlmi.rhcloud.com/r/1647/diff/1/?file=9117#file9117line154" style="color: black; font-weight: bold; text-decoration: underline;">cmake/modules/OpenLMIMacros.cmake</a> <span style="font-weight: normal;"> (Diff revision 1) </span> </th> </tr> </thead> <tbody> <tr> <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">154</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">if</span> <span class="o">${</span><span class="nv">PROFILE_DO_REG</span><span class="o">}</span><span class="s">\;</span> <span class="s">then</span> <span class="o">${</span><span class="nv">OPENLMI_MOF_REGISTER</span><span class="o">}</span> <span class="s">--just-mofs</span> <span class="s">-n</span> <span class="s">root/interop</span> <span class="s">register</span> <span class="o">${</span><span class="nv">PROFILE</span><span class="o">}</span><span class="s">\;</span> <span class="s">fi</span><span class="p">)</span></pre></td> </tr> </tbody> </table> <pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The profile (un-)registration works only in Pegasus, please add &#39;-c tog-pegasus&#39;.</pre> </div> <br /> <p>- Jan Safranek</p> <br /> <p>On April 28th, 2014, 1:14 p.m. CEST, Tomáš Bžatek wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Tomáš Bžatek.</div> <p style="color: grey;"><i>Updated April 28, 2014, 1:14 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is an attempt to include profile (un)registration within the (un)register-PROVIDER make target. This commit extends the cim_registration macro by an extra argument of the profile file. However it is currently limited to a single argument.</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>cmake/modules/OpenLMIMacros.cmake <span style="color: grey">(d55f983d2589bb3bee1a14668275b2ed96142cfa)</span></li> <li>src/account/CMakeLists.txt <span style="color: grey">(83ca474a00a3a8a514bed4fc787360563ad56d01)</span></li> <li>src/fan/CMakeLists.txt <span style="color: grey">(446e38b820ad53ae28b619df538c49f03a33bb69)</span></li> <li>src/hardware/CMakeLists.txt <span style="color: grey">(29b63d342039a2e19a1fcdfe626cfab2b3a3002f)</span></li> <li>src/journald/CMakeLists.txt <span style="color: grey">(1e6f19372172e5410f7b902ab5f61cac262fdf69)</span></li> <li>src/logicalfile/CMakeLists.txt <span style="color: grey">(3a09a4ad7a545f8a74f73175461943516e3f8fde)</span></li> <li>src/power/CMakeLists.txt <span style="color: grey">(44b2109ec5ce0c41c6d7091144bd58c0a86e84a2)</span></li> <li>src/realmd/CMakeLists.txt <span style="color: grey">(dbf2e5463d9192d6dc1dbf767c7be1242e67eb11)</span></li> <li>src/service-dbus/CMakeLists.txt <span style="color: grey">(4ba32316993c78ec6ae41287fc97867e23fcf098)</span></li> <li>src/service/CMakeLists.txt <span style="color: grey">(6d75d38247a8c06b8f6b5e5f4d3b1f8615c910d9)</span></li> <li>src/software-dbus/CMakeLists.txt <span style="color: grey">(5202c33e302bca4b1a48f71bcdf884ff4e1ba01e)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1647/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============5860409415448089677==-- ]