[From nobody Thu Feb 13 12:00:16 2014 From: Radek Novacek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Peter Schiffer" <pschiffe@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org>, "Radek Novacek" <rnovacek@redhat.com> References: <20140212133405.8566.1753@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20140212133405.8566.1753@ex-std-node147.prod.rhcloud.com> Date: Wed, 12 Feb 2014 14:10:29 -0000 Reply-To: Radek Novacek <rnovacek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140212141029.8567.43866@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============2670556851717901711==" Subject: Re: Review Request 1521: Hardware: added VirtualMachine field to the Chassis provider Message: 8 --===============2670556851717901711== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1521/#review2253 ----------------------------------------------------------- Ship it! src/hardware/LMI_ChassisProvider.c <http://reviewboard-openlmi.rhcloud.com/r/1521/#comment1215> virt is not freed. src/hardware/virt_what.h <http://reviewboard-openlmi.rhcloud.com/r/1521/#comment1216> This should be in source file not in the header. These are only minor issues. Fix and ship - Radek Novacek On Feb. 12, 2014, 2:34 p.m., Peter Schiffer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1521/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 2:34 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > Hardware: added VirtualMachine field to the Chassis provider > > > Diffs > ----- > > mof/60_LMI_Hardware.mof 4639978b6aead69497072ade1b4109789fccd5ef > openlmi-providers.spec 484c403e738490f9ed5c0d5b5d57221a692f6561 > src/hardware/CMakeLists.txt 74a20d05ee17846c886f96ff53e1a352b8658794 > src/hardware/LMI_ChassisProvider.c 21eb83ec3295cddd132631030615d3823316dfa3 > src/hardware/virt_what.h PRE-CREATION > src/hardware/virt_what.c PRE-CREATION > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1521/diff/ > > > Testing > ------- > > > Thanks, > > Peter Schiffer > > --===============2670556851717901711== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1521/">http://reviewboard-openlmi.rhcloud.com/r/1521/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <div> <table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;"> <thead> <tr> <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;"> <a href="http://reviewboard-openlmi.rhcloud.com/r/1521/diff/1/?file=8465#file8465line110" style="color: black; font-weight: bold; text-decoration: underline;">src/hardware/LMI_ChassisProvider.c</a> <span style="font-weight: normal;"> (Diff revision 1) </span> </th> </tr> </thead> <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;"> <tr> <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static CMPIStatus LMI_ChassisEnumInstances(</pre></td> </tr> </tbody> <tbody> <tr> <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">110</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">virt_what_get_virtual_type</span><span class="p">(</span><span class="o">&amp;</span><span class="n">virt</span><span class="p">)</span> <span class="o">==</span> <span class="mi">0</span> <span class="o">&amp;&amp;</span> <span class="n">virt</span> <span class="o">&amp;&amp;</span> <span class="n">strlen</span><span class="p">(</span><span class="n">virt</span><span class="p">))</span> <span class="p">{</span></pre></td> </tr> </tbody> </table> <pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">virt is not freed.</pre> </div> <br /> <div> <table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;"> <thead> <tr> <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;"> <a href="http://reviewboard-openlmi.rhcloud.com/r/1521/diff/1/?file=8466#file8466line24" style="color: black; font-weight: bold; text-decoration: underline;">src/hardware/virt_what.h</a> <span style="font-weight: normal;"> (Diff revision 1) </span> </th> </tr> </thead> <tbody> <tr> <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include &quot;utils.h&quot;</span></pre></td> </tr> </tbody> </table> <pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should be in source file not in the header.</pre> </div> <br /> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These are only minor issues. Fix and ship</pre> <p>- Radek Novacek</p> <br /> <p>On February 12th, 2014, 2:34 p.m. CET, Peter Schiffer wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Peter Schiffer.</div> <p style="color: grey;"><i>Updated Feb. 12, 2014, 2:34 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hardware: added VirtualMachine field to the Chassis provider</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>mof/60_LMI_Hardware.mof <span style="color: grey">(4639978b6aead69497072ade1b4109789fccd5ef)</span></li> <li>openlmi-providers.spec <span style="color: grey">(484c403e738490f9ed5c0d5b5d57221a692f6561)</span></li> <li>src/hardware/CMakeLists.txt <span style="color: grey">(74a20d05ee17846c886f96ff53e1a352b8658794)</span></li> <li>src/hardware/LMI_ChassisProvider.c <span style="color: grey">(21eb83ec3295cddd132631030615d3823316dfa3)</span></li> <li>src/hardware/virt_what.h <span style="color: grey">(PRE-CREATION)</span></li> <li>src/hardware/virt_what.c <span style="color: grey">(PRE-CREATION)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1521/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============2670556851717901711==-- ]