[From nobody Thu Feb 13 12:00:16 2014 From: Michal Minar <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Michal Minar" <miminar@redhat.com>, "Peter Hatina" <phatina@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org> References: <20140212112718.8566.25746@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20140212112718.8566.25746@ex-std-node147.prod.rhcloud.com> Date: Wed, 12 Feb 2014 12:04:12 -0000 Reply-To: Michal Minar <miminar@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140212120412.8566.16541@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============5595764087514283639==" Subject: Re: Review Request 1520: tools [1/1] logging: get the logger with name of a module Message: 2 --===============5595764087514283639== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1520/ ----------------------------------------------------------- (Updated Feb. 12, 2014, 12:04 p.m.) Status ------ This change has been marked as submitted. Review request for OpenLMI Developers. Repository: openlmi-tools Description ------- logging: get the logger with name of a module Allow to configure shell's logging facilities from dependent applications. Using module's name as a name for a logger is a convetion greatly simplifying logging's setup. Diffs ----- cli/lmi/shell/LMIConnection.py ef83a8a311115b747df27712fc9cb3c82ab2f41e Diff: http://reviewboard-openlmi.rhcloud.com/r/1520/diff/ Testing ------- Thanks, Michal Minar --===============5595764087514283639== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1520/">http://reviewboard-openlmi.rhcloud.com/r/1520/</a> </td> </tr> </table> <br /> <table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;"> <tr> <td> <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1> </td> </tr> </table> <br /> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Michal Minar.</div> <p style="color: grey;"><i>Updated Feb. 12, 2014, 12:04 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-tools </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">logging: get the logger with name of a module Allow to configure shell&#39;s logging facilities from dependent applications. Using module&#39;s name as a name for a logger is a convetion greatly simplifying logging&#39;s setup. </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>cli/lmi/shell/LMIConnection.py <span style="color: grey">(ef83a8a311115b747df27712fc9cb3c82ab2f41e)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1520/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============5595764087514283639==-- ]