[From nobody Tue Feb 11 12:00:15 2014 From: Jan Synacek <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Peter Schiffer" <pschiffe@redhat.com>, "Jan Synacek" <jsynacek@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org> References: <20140210172221.8567.46028@ex-std-node147.prod.rhcloud.com> In-Reply-To: <20140210172221.8567.46028@ex-std-node147.prod.rhcloud.com> Date: Tue, 11 Feb 2014 07:36:58 -0000 Reply-To: Jan Synacek <jsynacek@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140211073658.8567.26252@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============7192560976911318845==" Subject: Re: Review Request 1518: Hardware: added temperature to the DiskDriveProvider Message: 18 --===============7192560976911318845== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1518/#review2245 ----------------------------------------------------------- Ship it! Ship It! - Jan Synacek On Feb. 10, 2014, 6:22 p.m., Peter Schiffer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/1518/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2014, 6:22 p.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > Hardware: added temperature to the DiskDriveProvider > > > Diffs > ----- > > mof/60_LMI_Hardware.mof f0a06592d234135162289e1637eb48e81ba140eb > src/hardware/LMI_DiskDriveProvider.c cfc9ef5bbf2d9cc61519af1fef76e8c726400b53 > src/hardware/smartctl.h 8b277e3b7bb36f453562722ab852ba242952894e > src/hardware/smartctl.c b1b0ce71b81c3c1b6c3ad52fe92d7f384a0fb7d9 > > Diff: http://reviewboard-openlmi.rhcloud.com/r/1518/diff/ > > > Testing > ------- > > > Thanks, > > Peter Schiffer > > --===============7192560976911318845== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1518/">http://reviewboard-openlmi.rhcloud.com/r/1518/</a> </td> </tr> </table> <br /> <p>Ship it!</p> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br /> <p>- Jan Synacek</p> <br /> <p>On February 10th, 2014, 6:22 p.m. CET, Peter Schiffer wrote:</p> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Peter Schiffer.</div> <p style="color: grey;"><i>Updated Feb. 10, 2014, 6:22 p.m.</i></p> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hardware: added temperature to the DiskDriveProvider</pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>mof/60_LMI_Hardware.mof <span style="color: grey">(f0a06592d234135162289e1637eb48e81ba140eb)</span></li> <li>src/hardware/LMI_DiskDriveProvider.c <span style="color: grey">(cfc9ef5bbf2d9cc61519af1fef76e8c726400b53)</span></li> <li>src/hardware/smartctl.h <span style="color: grey">(8b277e3b7bb36f453562722ab852ba242952894e)</span></li> <li>src/hardware/smartctl.c <span style="color: grey">(b1b0ce71b81c3c1b6c3ad52fe92d7f384a0fb7d9)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1518/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============7192560976911318845==-- ]