[From nobody Thu Jan 9 12:00:14 2014 From: Michal Minar <reviewboard@gallagherhome.com> Precedence: list MIME-Version: 1.0 To: "Michal Minar" <miminar@redhat.com>, "OpenLMI Developers" <openlmi-reviews@lists.fedorahosted.org> Date: Wed, 08 Jan 2014 15:20:06 -0000 Reply-To: Michal Minar <miminar@redhat.com>, openlmi-reviews@lists.fedorahosted.org Message-ID: <20140108152006.218155.2041@ex-std-node147.prod.rhcloud.com> Content-Type: multipart/alternative; boundary="===============5908522120752024631==" Subject: Review Request 1439: providers [1/1] tests: ensure the use of exceptions is well defined Message: 7 --===============5908522120752024631== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1439/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- tests: ensure the use of exceptions is well defined Some tests expect that exceptions won't be thrown out of LMIShell's functions. Others prefers them and enable them globally. This causes problems when running under nosetests all provider tests at once. Tests that modified enablement of exception throws globally caused others to fail. This patch makes sure that each TestCase has defined use of exceptions. Default state is to have them disabled. If a TestCase prefers having them enabled, just one variable needs to be overriden in its body: class AccountBase(lmibase.LmiTestCase): USE_EXCEPTIONS = True Diffs ----- src/account/test/common.py 8bb18e2a9a2980a78aaba2d79f5dd1ea664929e2 src/journald/test/journald_common.py 60ce15e50ee5c47127660865854ba0cf70d2bc33 src/python/lmi/test/lmibase.py 242c002479eb9748235ba41bf5694bc2e5735a5a src/software/test/swbase.py 7c2de1ed7dda1536fa5e6269df1b810ad1434a47 Diff: http://reviewboard-openlmi.rhcloud.com/r/1439/diff/ Testing ------- Thanks, Michal Minar --===============5908522120752024631== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit <html> <body> <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;"> <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;"> <tr> <td> This is an automatically generated e-mail. To reply, visit: <a href="http://reviewboard-openlmi.rhcloud.com/r/1439/">http://reviewboard-openlmi.rhcloud.com/r/1439/</a> </td> </tr> </table> <br /> <table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr> <td> <div>Review request for OpenLMI Developers.</div> <div>By Michal Minar.</div> <div style="margin-top: 1.5em;"> <b style="color: #575012; font-size: 10pt;">Repository: </b> openlmi-providers </div> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0"> <tr> <td> <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tests: ensure the use of exceptions is well defined Some tests expect that exceptions won&#39;t be thrown out of LMIShell&#39;s functions. Others prefers them and enable them globally. This causes problems when running under nosetests all provider tests at once. Tests that modified enablement of exception throws globally caused others to fail. This patch makes sure that each TestCase has defined use of exceptions. Default state is to have them disabled. If a TestCase prefers having them enabled, just one variable needs to be overriden in its body: class AccountBase(lmibase.LmiTestCase): USE_EXCEPTIONS = True </pre> </td> </tr> </table> <h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1> <ul style="margin-left: 3em; padding-left: 0;"> <li>src/account/test/common.py <span style="color: grey">(8bb18e2a9a2980a78aaba2d79f5dd1ea664929e2)</span></li> <li>src/journald/test/journald_common.py <span style="color: grey">(60ce15e50ee5c47127660865854ba0cf70d2bc33)</span></li> <li>src/python/lmi/test/lmibase.py <span style="color: grey">(242c002479eb9748235ba41bf5694bc2e5735a5a)</span></li> <li>src/software/test/swbase.py <span style="color: grey">(7c2de1ed7dda1536fa5e6269df1b810ad1434a47)</span></li> </ul> <p><a href="http://reviewboard-openlmi.rhcloud.com/r/1439/diff/" style="margin-left: 3em;">View Diff</a></p> </td> </tr> </table> </div> </body> </html> --===============5908522120752024631==-- ]